rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix lint

Browse Source
This commit is contained in:
Florian Bruhin 2016-07-15 15:52:48 +02:00
parent e2c4e6301f
commit d710a98f46
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
qutebrowser/browser/webengine/webenginetab.py
View File

@ -189,6 +189,12 @@ class WebEngineScroller(browsertab.AbstractScroller):
def _init_widget(self, widget): def _init_widget(self, widget):
super()._init_widget(widget) super()._init_widget(widget)
page = widget.page()
try:
page.scrollPositionChanged.connect(
self._on_scroll_pos_changed)
except AttributeError:
log.stub('scrollPositionChanged, on Qt < 5.7')
self._on_scroll_pos_changed() self._on_scroll_pos_changed()
def _key_press(self, key, count=1): def _key_press(self, key, count=1):
@ -204,7 +210,9 @@ class WebEngineScroller(browsertab.AbstractScroller):
@pyqtSlot() @pyqtSlot()
def _on_scroll_pos_changed(self): def _on_scroll_pos_changed(self):
"""Update the scroll position attributes when it changed."""
def update_scroll_pos(jsret): def update_scroll_pos(jsret):
"""Callback after getting scroll position via JS."""
assert isinstance(jsret, dict) assert isinstance(jsret, dict)
self._pos_perc = (jsret['perc']['x'], jsret['perc']['y']) self._pos_perc = (jsret['perc']['x'], jsret['perc']['y'])
self._pos_px = QPoint(jsret['px']['x'], jsret['px']['y']) self._pos_px = QPoint(jsret['px']['x'], jsret['px']['y'])
@ -419,8 +427,3 @@ class WebEngineTab(browsertab.AbstractTab):
view.iconChanged.connect(self.icon_changed) view.iconChanged.connect(self.icon_changed)
except AttributeError: except AttributeError:
log.stub('iconChanged, on Qt < 5.7') log.stub('iconChanged, on Qt < 5.7')
try:
page.scrollPositionChanged.connect(
self.scroll._on_scroll_pos_changed)
except AttributeError:
log.stub('scrollPositionChanged, on Qt < 5.7')