From d695baf355ac1e825776ce8ed16f1b492a0fe74f Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sat, 21 Jun 2014 23:05:26 +0200 Subject: [PATCH] Reply with error reply on invalid qute:* URLs. --- qutebrowser/network/qutescheme.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/qutebrowser/network/qutescheme.py b/qutebrowser/network/qutescheme.py index 1afd568cf..988434703 100644 --- a/qutebrowser/network/qutescheme.py +++ b/qutebrowser/network/qutescheme.py @@ -24,13 +24,16 @@ Module attributes: pyeval_output: The output of the last :pyeval command. """ -import qutebrowser import cgi +from PyQt5.QtNetwork import QNetworkReply + +import qutebrowser import qutebrowser.utils.log as logutils import qutebrowser.utils.version as version from qutebrowser.network.schemehandler import (SchemeHandler, - SpecialNetworkReply) + SpecialNetworkReply, + ErrorNetworkReply) from qutebrowser.utils.misc import read_file @@ -87,8 +90,9 @@ class QuteSchemeHandler(SchemeHandler): try: handler = getattr(QuteHandlers, path) except AttributeError: - logutils.misc.warning("No handler found for {}!".format(path)) - data = bytes() + return ErrorNetworkReply( + request, "No handler found for {}!".format(path), + QNetworkReply.ContentNotFoundError, self.parent()) else: data = handler() return SpecialNetworkReply(request, data, 'text/html', self.parent())