rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix expected data in AppendLineParser test

Browse Source 
There were two different issues here:

- `\n` rather than `os.linesep` was used, which caused the "generated"
  file to have less data in it than expected
- A final `os.linesep` (or `\n`) was missing, but that was cancelled out
  by a off-by-one error when slicing, so wasn't an issue until we tried
  with \r\n endings.
This commit is contained in:
Florian Bruhin 2016-06-09 10:26:09 +02:00
parent c5c022226f
commit d6926f0622
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/misc/test_lineparser.py
View File

@ -147,6 +147,6 @@ class TestAppendLineParser:
new_data = ['new data {}'.format(i) for i in range(size)] new_data = ['new data {}'.format(i) for i in range(size)]
lineparser.new_data = new_data lineparser.new_data = new_data
lineparser.save() lineparser.save()
data = '\n'.join(self.BASE_DATA + new_data) data = os.linesep.join(self.BASE_DATA + new_data) + os.linesep
data = [e + '\n' for e in data[-(size - 1):].splitlines()] data = [e + '\n' for e in data[-size:].splitlines()]
assert lineparser.get_recent(size) == data assert lineparser.get_recent(size) == data