From 96e3a0b1f17af595e21f59aec47ae355a9806b4d Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Thu, 3 Sep 2015 17:24:01 +0200 Subject: [PATCH 1/7] first cookie tests --- qutebrowser/browser/cookies.py | 22 +++-- tests/helpers/stubs.py | 5 + tests/unit/browser/test_cookies.py | 148 +++++++++++++++++++++++++++++ 3 files changed, 168 insertions(+), 7 deletions(-) create mode 100644 tests/unit/browser/test_cookies.py diff --git a/qutebrowser/browser/cookies.py b/qutebrowser/browser/cookies.py index 0c6b8c036..c8c751b4f 100644 --- a/qutebrowser/browser/cookies.py +++ b/qutebrowser/browser/cookies.py @@ -68,19 +68,27 @@ class CookieJar(RAMCookieJar): _lineparser: The LineParser managing the cookies file. """ - def __init__(self, parent=None): + def __init__(self, parent=None, line_parser=None): super().__init__(parent) - self._lineparser = lineparser.LineParser( - standarddir.data(), 'cookies', binary=True, parent=self) - cookies = [] - for line in self._lineparser: - cookies += QNetworkCookie.parseCookies(line) - self.setAllCookies(cookies) + + if line_parser: + self._lineparser = line_parser + else: + self._lineparser = lineparser.LineParser( + standarddir.data(), 'cookies', binary=True, parent=self) + self.parse_cookies() objreg.get('config').changed.connect(self.cookies_store_changed) objreg.get('save-manager').add_saveable( 'cookies', self.save, self.changed, config_opt=('content', 'cookies-store')) + def parse_cookies(self): + """Parse cookies from lineparser and store them.""" + cookies = [] + for line in self._lineparser: + cookies += QNetworkCookie.parseCookies(line) + self.setAllCookies(cookies) + def purge_old_cookies(self): """Purge expired cookies from the cookie jar.""" # Based on: diff --git a/tests/helpers/stubs.py b/tests/helpers/stubs.py index 53d97e0a0..59eba35d3 100644 --- a/tests/helpers/stubs.py +++ b/tests/helpers/stubs.py @@ -324,6 +324,11 @@ class ConfigStub(QObject): def __getitem__(self, name): return self.section(name) + def __setattr__(self, name, value): + if name == 'data': + self.changed.emit('', '') + super().__setattr__(name, value) + def section(self, name): """Get a section from the config. diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py new file mode 100644 index 000000000..d5efbcc18 --- /dev/null +++ b/tests/unit/browser/test_cookies.py @@ -0,0 +1,148 @@ +# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: + +# Copyright 2015 Alexander Cogneau (acogneau) : +# +# This file is part of qutebrowser. +# +# qutebrowser is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# qutebrowser is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with qutebrowser. If not, see . + +"""Tests for qutebrowser.browser.cookies""" + +from unittest import mock + +from PyQt5.QtNetwork import QNetworkCookie +from PyQt5.QtTest import QSignalSpy +from PyQt5.QtCore import QUrl +import pytest + +from qutebrowser.browser import cookies +from qutebrowser.utils import objreg +from qutebrowser.misc import lineparser + +CONFIG_ALL_COOKIES = {'content': {'cookies-accept': 'all'}} +CONFIG_NEVER_COOKIES = {'content': {'cookies-accept': 'never'}} +CONFIG_COOKIES_ENABLED = {'content': {'cookies-store': True}} +CONFIG_COOKIES_DISABLED = {'content': {'cookies-store': False}} + + +cookie1 = b'foo1=bar; expires=Tue, 01-Jan-2036 08:00:01 GMT' +cookie2 = b'foo2=bar; expires=Tue, 01-Jan-2036 08:00:01 GMT' +session_cookie = b'foo3=bar' +expired_cookie = b'foo4=bar; expires=Sat, 01-Jan-2000 08:00:01 GMT' + + +class LineparserSaveStub(lineparser.LineParser): + """A stub for LineParser's save() + + Attributes: + saved: The .data before save() + """ + + def save(self): + self.saved = self.data + super().save() + + +@pytest.yield_fixture +def fake_save_manager(): + """Create a mock of save-manager and register it into objreg.""" + fake_save_manager = mock.Mock() + objreg.register('save-manager', fake_save_manager) + yield + objreg.delete('save-manager') + +"""Tests for RAMCookieJar.""" + + +def test_set_cookies_accept(config_stub, qtbot, monkeypatch): + """Test setCookiesFromUrl with cookies enabled.""" + config_stub.data = CONFIG_ALL_COOKIES + ram_jar = cookies.RAMCookieJar() + cookie = QNetworkCookie(b'foo', b'bar') + url = QUrl('http://example.com/') + with qtbot.waitSignal(ram_jar.changed, raising=True): + assert ram_jar.setCookiesFromUrl([cookie], url) + + # assert the cookies are added correctly + all_cookies = ram_jar.cookiesForUrl(url) + assert len(all_cookies) == 1 + saved_cookie = all_cookies[0] + assert (saved_cookie.name(), + saved_cookie.value()) == (cookie.name(), cookie.value()) + + +def test_set_cookies_never_accept(config_stub): + """Test setCookiesFromUrl when cookies are not accepted.""" + config_stub.data = CONFIG_NEVER_COOKIES + ram_jar = cookies.RAMCookieJar() + error_signal_spy = QSignalSpy(ram_jar.changed) + + assert not ram_jar.setCookiesFromUrl('test', 'test') + assert len(error_signal_spy) == 0 + + +def test_cookie_jar_init(config_stub, fake_save_manager): + """Test the CookieJar constructor.""" + line_parser_stub = [cookie1, cookie2] + jar = cookies.CookieJar(line_parser=line_parser_stub) + assert objreg.get('save-manager').add_saveable.called + + # Test that cookies are added to the jar + assert len(jar.allCookies()) == 2 + assert jar.allCookies()[0].toRawForm().data() == cookie1 + assert jar.allCookies()[1].toRawForm().data() == cookie2 + + +def test_purge_old_cookies(config_stub, fake_save_manager): + """Test that expired cookies are deleted.""" + line_parser_stub = [cookie1, cookie2, session_cookie, expired_cookie] + jar = cookies.CookieJar(line_parser=line_parser_stub) + + assert len(jar.allCookies()) == 4 + jar.purge_old_cookies() + assert len(jar.allCookies()) == 3 + assert jar.allCookies()[0].toRawForm().data() == cookie1 + assert jar.allCookies()[1].toRawForm().data() == cookie2 + assert jar.allCookies()[2].toRawForm().data() == session_cookie + + +def test_save(config_stub, fake_save_manager, monkeypatch): + """Test that expired and session cookies are not saved.""" + monkeypatch.setattr(lineparser, + 'LineParser', LineparserSaveStub) + + jar = cookies.CookieJar() + jar._lineparser.data = [cookie1, cookie2, session_cookie, expired_cookie] + + # update the cookies on the jar itself + jar.parse_cookies() + jar.save() + assert len(jar._lineparser.saved) == 2 + assert jar._lineparser.saved[0].data() == cookie1 + assert jar._lineparser.saved[1].data() == cookie2 + + +def test_cookies_changed(config_stub, fake_save_manager, monkeypatch, qtbot): + """Test that self.changed is emitted and cookies are not saved.""" + config_stub.data = CONFIG_COOKIES_ENABLED + monkeypatch.setattr(lineparser, + 'LineParser', LineparserSaveStub) + jar = cookies.CookieJar() + + # Test that signal is emitted + with qtbot.waitSignal(jar.changed, raising=True): + config_stub.data == CONFIG_COOKIES_DISABLED + + # test that cookies aren't saved + assert len(jar._lineparser.saved) == 0 From 418328e61be05ba62ad1ab0855ed57413f883256 Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Thu, 3 Sep 2015 18:17:39 +0200 Subject: [PATCH 2/7] Cookie tests done --- scripts/dev/check_coverage.py | 1 + tests/helpers/stubs.py | 14 +++++++++----- tests/unit/browser/test_cookies.py | 15 ++++++++------- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/scripts/dev/check_coverage.py b/scripts/dev/check_coverage.py index e4eb71d24..863cf40e1 100644 --- a/scripts/dev/check_coverage.py +++ b/scripts/dev/check_coverage.py @@ -37,6 +37,7 @@ PERFECT_FILES = [ 'qutebrowser/commands/cmdutils.py', 'qutebrowser/commands/argparser.py', + 'qutebrowser/browser/cookies.py', 'qutebrowser/browser/tabhistory.py', 'qutebrowser/browser/http.py', 'qutebrowser/browser/rfc6266.py', diff --git a/tests/helpers/stubs.py b/tests/helpers/stubs.py index 59eba35d3..54b2b3142 100644 --- a/tests/helpers/stubs.py +++ b/tests/helpers/stubs.py @@ -324,11 +324,6 @@ class ConfigStub(QObject): def __getitem__(self, name): return self.section(name) - def __setattr__(self, name, value): - if name == 'data': - self.changed.emit('', '') - super().__setattr__(name, value) - def section(self, name): """Get a section from the config. @@ -348,6 +343,15 @@ class ConfigStub(QObject): except KeyError: raise configexc.NoOptionError(opt, sect) + def set(self, sect, opt, value): + """Set a value in the config.""" + data = self.data[sect] + try: + data[opt] = value + self.changed.emit(sect, opt) + except KeyError: + raise configexc.NoOptionError(opt, sect) + class KeyConfigStub: diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py index d5efbcc18..235aa6378 100644 --- a/tests/unit/browser/test_cookies.py +++ b/tests/unit/browser/test_cookies.py @@ -33,7 +33,6 @@ from qutebrowser.misc import lineparser CONFIG_ALL_COOKIES = {'content': {'cookies-accept': 'all'}} CONFIG_NEVER_COOKIES = {'content': {'cookies-accept': 'never'}} CONFIG_COOKIES_ENABLED = {'content': {'cookies-store': True}} -CONFIG_COOKIES_DISABLED = {'content': {'cookies-store': False}} cookie1 = b'foo1=bar; expires=Tue, 01-Jan-2036 08:00:01 GMT' @@ -62,8 +61,6 @@ def fake_save_manager(): yield objreg.delete('save-manager') -"""Tests for RAMCookieJar.""" - def test_set_cookies_accept(config_stub, qtbot, monkeypatch): """Test setCookiesFromUrl with cookies enabled.""" @@ -110,7 +107,10 @@ def test_purge_old_cookies(config_stub, fake_save_manager): jar = cookies.CookieJar(line_parser=line_parser_stub) assert len(jar.allCookies()) == 4 + jar.purge_old_cookies() + + # Test that old cookies are gone assert len(jar.allCookies()) == 3 assert jar.allCookies()[0].toRawForm().data() == cookie1 assert jar.allCookies()[1].toRawForm().data() == cookie2 @@ -125,7 +125,7 @@ def test_save(config_stub, fake_save_manager, monkeypatch): jar = cookies.CookieJar() jar._lineparser.data = [cookie1, cookie2, session_cookie, expired_cookie] - # update the cookies on the jar itself + # Update the cookies on the jar itself jar.parse_cookies() jar.save() assert len(jar._lineparser.saved) == 2 @@ -139,10 +139,11 @@ def test_cookies_changed(config_stub, fake_save_manager, monkeypatch, qtbot): monkeypatch.setattr(lineparser, 'LineParser', LineparserSaveStub) jar = cookies.CookieJar() + jar._lineparser.data = [cookie1, cookie2] - # Test that signal is emitted + # Test that cookies are not saved with qtbot.waitSignal(jar.changed, raising=True): - config_stub.data == CONFIG_COOKIES_DISABLED + config_stub.set('content', 'cookies-store', False) - # test that cookies aren't saved + # Test that cookies are not saved assert len(jar._lineparser.saved) == 0 From d36c701b07c06f83578959c3a3242d3991a1cce6 Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Fri, 4 Sep 2015 11:44:59 +0200 Subject: [PATCH 3/7] Fixed comments --- qutebrowser/browser/cookies.py | 2 +- tests/unit/browser/test_cookies.py | 62 ++++++++++++++++++++++-------- 2 files changed, 47 insertions(+), 17 deletions(-) diff --git a/qutebrowser/browser/cookies.py b/qutebrowser/browser/cookies.py index c8c751b4f..5003d7044 100644 --- a/qutebrowser/browser/cookies.py +++ b/qutebrowser/browser/cookies.py @@ -68,7 +68,7 @@ class CookieJar(RAMCookieJar): _lineparser: The LineParser managing the cookies file. """ - def __init__(self, parent=None, line_parser=None): + def __init__(self, parent=None, *, line_parser=None): super().__init__(parent) if line_parser: diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py index 235aa6378..e92eb4ab5 100644 --- a/tests/unit/browser/test_cookies.py +++ b/tests/unit/browser/test_cookies.py @@ -41,16 +41,27 @@ session_cookie = b'foo3=bar' expired_cookie = b'foo4=bar; expires=Sat, 01-Jan-2000 08:00:01 GMT' -class LineparserSaveStub(lineparser.LineParser): +class LineparserSaveStub(lineparser.BaseLineParser): """A stub for LineParser's save() Attributes: + data: The data before the write saved: The .data before save() """ + def __init__(self, configdir, fname, *, binary=False, parent=None): + self.saved = [] + self.data = [] + return super().__init__(configdir, fname, binary=binary, parent=parent) + def save(self): self.saved = self.data - super().save() + + def __iter__(self): + return iter(self.data) + + def __getitem__(self, key): + return self.data[key] @pytest.yield_fixture @@ -75,18 +86,18 @@ def test_set_cookies_accept(config_stub, qtbot, monkeypatch): all_cookies = ram_jar.cookiesForUrl(url) assert len(all_cookies) == 1 saved_cookie = all_cookies[0] - assert (saved_cookie.name(), - saved_cookie.value()) == (cookie.name(), cookie.value()) + expected = cookie.name(), cookie.value() + assert saved_cookie.name(), saved_cookie.value() == expected def test_set_cookies_never_accept(config_stub): """Test setCookiesFromUrl when cookies are not accepted.""" config_stub.data = CONFIG_NEVER_COOKIES ram_jar = cookies.RAMCookieJar() - error_signal_spy = QSignalSpy(ram_jar.changed) + changed_signal_spy = QSignalSpy(ram_jar.changed) assert not ram_jar.setCookiesFromUrl('test', 'test') - assert len(error_signal_spy) == 0 + assert not changed_signal_spy def test_cookie_jar_init(config_stub, fake_save_manager): @@ -97,8 +108,9 @@ def test_cookie_jar_init(config_stub, fake_save_manager): # Test that cookies are added to the jar assert len(jar.allCookies()) == 2 - assert jar.allCookies()[0].toRawForm().data() == cookie1 - assert jar.allCookies()[1].toRawForm().data() == cookie2 + raw_cookies = [c.toRawForm().data() for c in jar.allCookies()] + assert raw_cookies[0] == cookie1 + assert raw_cookies[1] == cookie2 def test_purge_old_cookies(config_stub, fake_save_manager): @@ -133,17 +145,35 @@ def test_save(config_stub, fake_save_manager, monkeypatch): assert jar._lineparser.saved[1].data() == cookie2 -def test_cookies_changed(config_stub, fake_save_manager, monkeypatch, qtbot): - """Test that self.changed is emitted and cookies are not saved.""" +def test_cookies_changed_emit(config_stub, fake_save_manager, + monkeypatch, qtbot): + """Test that self.changed is emitted.""" + config_stub.data = CONFIG_COOKIES_ENABLED + monkeypatch.setattr(lineparser, + 'LineParser', LineparserSaveStub) + jar = cookies.CookieJar() + + with qtbot.waitSignal(jar.changed, raising=True): + config_stub.set('content', 'cookies-store', False) + + +@pytest.mark.parametrize('store_cookies,empty', [ + (True, False), + (False, True) + ]) +def test_cookies_changed(config_stub, fake_save_manager, monkeypatch, + qtbot, store_cookies, empty): + """Test that cookies are saved correctly.""" config_stub.data = CONFIG_COOKIES_ENABLED monkeypatch.setattr(lineparser, 'LineParser', LineparserSaveStub) jar = cookies.CookieJar() jar._lineparser.data = [cookie1, cookie2] + jar.parse_cookies() + config_stub.set('content', 'cookies-store', store_cookies) - # Test that cookies are not saved - with qtbot.waitSignal(jar.changed, raising=True): - config_stub.set('content', 'cookies-store', False) - - # Test that cookies are not saved - assert len(jar._lineparser.saved) == 0 + if empty: + assert not jar._lineparser.data + assert not jar._lineparser.saved + else: + assert jar._lineparser.data From 6541a360b1cbaa4c2e929c1e18a7c7461a5fb9c4 Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Sun, 6 Sep 2015 00:24:38 +0200 Subject: [PATCH 4/7] Final cooikies tests --- tests/unit/browser/test_cookies.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py index e92eb4ab5..b89ae8d06 100644 --- a/tests/unit/browser/test_cookies.py +++ b/tests/unit/browser/test_cookies.py @@ -157,6 +157,17 @@ def test_cookies_changed_emit(config_stub, fake_save_manager, config_stub.set('content', 'cookies-store', False) +def test_cookies_changed_not_emitted(config_stub, fake_save_manager, + monkeypatch): + """Test that changed is not emitted when nothing changes.""" + config_stub.data = CONFIG_COOKIES_ENABLED + monkeypatch.setattr(lineparser, + 'LineParser', LineparserSaveStub) + jar = cookies.CookieJar() + changed_spy = QSignalSpy(jar.changed) + assert len(changed_spy) == 0 + + @pytest.mark.parametrize('store_cookies,empty', [ (True, False), (False, True) From 851bf4cd312a12360201b5cc5b9b7d681b25c789 Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Sun, 6 Sep 2015 16:13:41 +0200 Subject: [PATCH 5/7] Fix pylint --- tests/unit/browser/test_cookies.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py index b89ae8d06..e5c6fa919 100644 --- a/tests/unit/browser/test_cookies.py +++ b/tests/unit/browser/test_cookies.py @@ -50,9 +50,9 @@ class LineparserSaveStub(lineparser.BaseLineParser): """ def __init__(self, configdir, fname, *, binary=False, parent=None): + super().__init__(configdir, fname, binary=binary, parent=parent) self.saved = [] self.data = [] - return super().__init__(configdir, fname, binary=binary, parent=parent) def save(self): self.saved = self.data From c08beda1aa6d15560301b0af51a51e7bfd9efc97 Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Sat, 12 Sep 2015 22:11:14 +0200 Subject: [PATCH 6/7] Code cleanup --- tests/unit/browser/test_cookies.py | 34 ++++++++++++++---------------- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py index e5c6fa919..912d2f4a5 100644 --- a/tests/unit/browser/test_cookies.py +++ b/tests/unit/browser/test_cookies.py @@ -28,7 +28,7 @@ import pytest from qutebrowser.browser import cookies from qutebrowser.utils import objreg -from qutebrowser.misc import lineparser +from qutebrowser.misc import lineparser, savemanager CONFIG_ALL_COOKIES = {'content': {'cookies-accept': 'all'}} CONFIG_NEVER_COOKIES = {'content': {'cookies-accept': 'never'}} @@ -49,8 +49,8 @@ class LineparserSaveStub(lineparser.BaseLineParser): saved: The .data before save() """ - def __init__(self, configdir, fname, *, binary=False, parent=None): - super().__init__(configdir, fname, binary=binary, parent=parent) + def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) self.saved = [] self.data = [] @@ -67,7 +67,7 @@ class LineparserSaveStub(lineparser.BaseLineParser): @pytest.yield_fixture def fake_save_manager(): """Create a mock of save-manager and register it into objreg.""" - fake_save_manager = mock.Mock() + fake_save_manager = mock.Mock(spec=savemanager.SaveManager) objreg.register('save-manager', fake_save_manager) yield objreg.delete('save-manager') @@ -96,8 +96,10 @@ def test_set_cookies_never_accept(config_stub): ram_jar = cookies.RAMCookieJar() changed_signal_spy = QSignalSpy(ram_jar.changed) - assert not ram_jar.setCookiesFromUrl('test', 'test') + url = QUrl('http://example.com/') + assert not ram_jar.setCookiesFromUrl(url, 'test') assert not changed_signal_spy + assert not ram_jar.getCookiesForUrl(url) def test_cookie_jar_init(config_stub, fake_save_manager): @@ -109,8 +111,7 @@ def test_cookie_jar_init(config_stub, fake_save_manager): # Test that cookies are added to the jar assert len(jar.allCookies()) == 2 raw_cookies = [c.toRawForm().data() for c in jar.allCookies()] - assert raw_cookies[0] == cookie1 - assert raw_cookies[1] == cookie2 + assert raw_cookies == [cookie1, cookie2] def test_purge_old_cookies(config_stub, fake_save_manager): @@ -123,10 +124,8 @@ def test_purge_old_cookies(config_stub, fake_save_manager): jar.purge_old_cookies() # Test that old cookies are gone - assert len(jar.allCookies()) == 3 - assert jar.allCookies()[0].toRawForm().data() == cookie1 - assert jar.allCookies()[1].toRawForm().data() == cookie2 - assert jar.allCookies()[2].toRawForm().data() == session_cookie + raw_cookies = [cookie.toRawForm().data() for cookie in jar.allCookies()] + assert raw_cookies == [cookie1, cookie2, session_cookie] def test_save(config_stub, fake_save_manager, monkeypatch): @@ -140,9 +139,8 @@ def test_save(config_stub, fake_save_manager, monkeypatch): # Update the cookies on the jar itself jar.parse_cookies() jar.save() - assert len(jar._lineparser.saved) == 2 - assert jar._lineparser.saved[0].data() == cookie1 - assert jar._lineparser.saved[1].data() == cookie2 + saved_cookies = [cookie.data() for cookie in jar._lineparser.saved] + assert saved_cookies == [cookie1, cookie2] def test_cookies_changed_emit(config_stub, fake_save_manager, @@ -165,13 +163,13 @@ def test_cookies_changed_not_emitted(config_stub, fake_save_manager, 'LineParser', LineparserSaveStub) jar = cookies.CookieJar() changed_spy = QSignalSpy(jar.changed) - assert len(changed_spy) == 0 + assert not changed_spy @pytest.mark.parametrize('store_cookies,empty', [ - (True, False), - (False, True) - ]) + (True, False), + (False, True) +]) def test_cookies_changed(config_stub, fake_save_manager, monkeypatch, qtbot, store_cookies, empty): """Test that cookies are saved correctly.""" From ec11a61ed846bf9f6fcb09d703738e22f080ee5d Mon Sep 17 00:00:00 2001 From: Alexander Cogneau Date: Sun, 13 Sep 2015 23:08:31 +0200 Subject: [PATCH 7/7] Fix failing tests --- tests/unit/browser/test_cookies.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/browser/test_cookies.py b/tests/unit/browser/test_cookies.py index 912d2f4a5..3d601be2f 100644 --- a/tests/unit/browser/test_cookies.py +++ b/tests/unit/browser/test_cookies.py @@ -99,7 +99,7 @@ def test_set_cookies_never_accept(config_stub): url = QUrl('http://example.com/') assert not ram_jar.setCookiesFromUrl(url, 'test') assert not changed_signal_spy - assert not ram_jar.getCookiesForUrl(url) + assert not ram_jar.cookiesForUrl(url) def test_cookie_jar_init(config_stub, fake_save_manager):