rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add error messages for QtWebEngine downloads

Browse Source 
Fixes #2164
This commit is contained in:
Florian Bruhin 2017-06-06 06:29:44 +02:00
parent 0e85342f57
commit d4f58533c0
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.asciidoc
View File

@ -70,6 +70,8 @@ Changed
closes the current tab. closes the current tab.
- (QtWebEngine) With Qt 5.9, `content -> cookies-store` can now be set without - (QtWebEngine) With Qt 5.9, `content -> cookies-store` can now be set without
a restart. a restart.
- (QtWebEngine) With Qt 5.9, better error messages are now shown for failed
downloads.
- The adblocker now also blocks non-GET requests (e.g. POST). - The adblocker now also blocks non-GET requests (e.g. POST).
- `javascript:` links can now be hinted. - `javascript:` links can now be hinted.
- `:view-source`, `:tab-clone` and `:navigate --tab` now don't open the tab as - `:view-source`, `:tab-clone` and `:navigate --tab` now don't open the tab as

7
qutebrowser/browser/webengine/webenginedownloads.py
View File

@ -77,7 +77,12 @@ class DownloadItem(downloads.AbstractDownloadItem):
elif state == QWebEngineDownloadItem.DownloadInterrupted: elif state == QWebEngineDownloadItem.DownloadInterrupted:
self.successful = False self.successful = False
# https://bugreports.qt.io/browse/QTBUG-56839 # https://bugreports.qt.io/browse/QTBUG-56839
self._die("Download failed") try:
reason = self._qt_item.interruptReasonString()
except AttributeError:
# Qt < 5.9
reason = "Download failed"
self._die(reason)
else: else:
raise ValueError("_on_state_changed was called with unknown state " raise ValueError("_on_state_changed was called with unknown state "
"{}".format(state_name)) "{}".format(state_name))