From e576ff608f263c7a3491e93fe894b07f8dc4c84c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 22 Aug 2014 07:54:48 +0200 Subject: [PATCH] utils.webelem: Don't treat select boxes as editable. --- qutebrowser/test/utils/test_webelem.py | 2 +- qutebrowser/utils/webelem.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qutebrowser/test/utils/test_webelem.py b/qutebrowser/test/utils/test_webelem.py index 502790702..b98425bec 100644 --- a/qutebrowser/test/utils/test_webelem.py +++ b/qutebrowser/test/utils/test_webelem.py @@ -368,7 +368,7 @@ class IsEditableTests(unittest.TestCase): def test_select(self): """Test selectbox.""" elem = FakeWebElement(tagname='select') - self.assertTrue(webelem.is_editable(elem)) + self.assertFalse(webelem.is_editable(elem)) def test_input_disabled(self): """Test disabled input element.""" diff --git a/qutebrowser/utils/webelem.py b/qutebrowser/utils/webelem.py index c33ca31b8..7dfc4cc08 100644 --- a/qutebrowser/utils/webelem.py +++ b/qutebrowser/utils/webelem.py @@ -258,7 +258,7 @@ def is_editable(elem, strict=False): return True elif tag == 'input': return _is_editable_input(elem) - elif tag in ('textarea', 'select'): + elif tag == 'textarea': return is_writable(elem) elif tag in ('embed', 'applet'): # Flash/Java/...