From 7a9f80bf9a8f47355709df8c8fa7222cedfbcba6 Mon Sep 17 00:00:00 2001 From: Kevin Velghe Date: Mon, 31 Oct 2016 18:01:25 +0100 Subject: [PATCH 1/3] Use jseval to test insert-text with js disabled --- tests/end2end/features/yankpaste.feature | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/end2end/features/yankpaste.feature b/tests/end2end/features/yankpaste.feature index f67c65103..5cace9f7e 100644 --- a/tests/end2end/features/yankpaste.feature +++ b/tests/end2end/features/yankpaste.feature @@ -260,14 +260,14 @@ Feature: Yanking and pasting. When I set general -> log-javascript-console to info And I set content -> allow-javascript to false And I open data/paste_primary.html + And I run :jseval document.getElementById('qute-textarea').addEventListener('input', function() { console.log("textarea contents: " + document.getElementById('qute-textarea').value); }); And I run :click-element id qute-textarea And I wait for "Clicked editable element!" in the log And I run :insert-text Hello world - And I press the keys "" - And I run :yank selection + # Enable javascript again for the other tests And I set content -> allow-javascript to true # Compare - Then the clipboard should contain "Hello world" + Then the javascript message "textarea contents: Hello world" should be logged Scenario: Inserting text into a text field at specific position When I set general -> log-javascript-console to info From 7a207f7678aeff6e9d7b4a4ba3bae2c61662e050 Mon Sep 17 00:00:00 2001 From: Kevin Velghe Date: Mon, 31 Oct 2016 19:34:32 +0100 Subject: [PATCH 2/3] There are no events when javascript is disabled --- tests/end2end/features/yankpaste.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/end2end/features/yankpaste.feature b/tests/end2end/features/yankpaste.feature index 5cace9f7e..b568f23fe 100644 --- a/tests/end2end/features/yankpaste.feature +++ b/tests/end2end/features/yankpaste.feature @@ -260,10 +260,10 @@ Feature: Yanking and pasting. When I set general -> log-javascript-console to info And I set content -> allow-javascript to false And I open data/paste_primary.html - And I run :jseval document.getElementById('qute-textarea').addEventListener('input', function() { console.log("textarea contents: " + document.getElementById('qute-textarea').value); }); And I run :click-element id qute-textarea And I wait for "Clicked editable element!" in the log And I run :insert-text Hello world + And I run :jseval console.log("textarea contents: " + document.getElementById('qute-textarea').value); # Enable javascript again for the other tests And I set content -> allow-javascript to true # Compare From 9c4086a3f3495a90969d31644b3059f186632d07 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 6 Nov 2016 22:42:02 +0100 Subject: [PATCH 3/3] Regenerate authors --- README.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.asciidoc b/README.asciidoc index 24598a780..b5ea0fb6d 100644 --- a/README.asciidoc +++ b/README.asciidoc @@ -156,8 +156,8 @@ Contributors, sorted by the number of commits in descending order: * Felix Van der Jeugt * Martin Tournoij * Daniel Karbach -* Raphael Pierzina * Kevin Velghe +* Raphael Pierzina * Joel Torstensson * Patric Schmitz * Tarcisio Fedrizzi