Fix feedback from #690

This commit is contained in:
Martin Tournoij 2015-05-29 14:49:52 +02:00
parent c76221c14e
commit d20872d576
4 changed files with 6 additions and 4 deletions

View File

@ -27,6 +27,6 @@
path=/tmp/qutebrowser_$(mktemp XXXXXXXX).html path=/tmp/qutebrowser_$(mktemp XXXXXXXX).html
curl "$QUTE_URL" > $path curl "$QUTE_URL" > $path
urxvt -e vim "$path" xterm -e vim "$path"
rm "$path" rm "$path"

View File

@ -70,7 +70,7 @@ def run(args):
sys.exit(usertypes.Exit.ok) sys.exit(usertypes.Exit.ok)
if args.temp_basedir: if args.temp_basedir:
args.basedir = tempfile.mkdtemp() args.basedir = tempfile.mkdtemp(prefix='qutebrowser-prefix-')
quitter = Quitter(args) quitter = Quitter(args)
objreg.register('quitter', quitter) objreg.register('quitter', quitter)

View File

@ -122,8 +122,8 @@ class ExternalEditor(QObject):
raise ValueError("Already editing a file!") raise ValueError("Already editing a file!")
self._text = text self._text = text
try: try:
self._oshandle, self._filename = tempfile.mkstemp(text=True, self._oshandle, self._filename = tempfile.mkstemp(
prefix='qutebrowser_editor_') text=True, prefix='qutebrowser-editor-')
if text: if text:
encoding = config.get('general', 'editor-encoding') encoding = config.get('general', 'editor-encoding')
with open(self._filename, 'w', encoding=encoding) as f: with open(self._filename, 'w', encoding=encoding) as f:

View File

@ -166,6 +166,7 @@ def fuzzy_url(urlstr, cwd=None, relative=False, do_search=True):
path = None path = None
stripped = urlstr.strip() stripped = urlstr.strip()
if path is not None and os.path.exists(path): if path is not None and os.path.exists(path):
log.url.debug("URL is a local file") log.url.debug("URL is a local file")
url = QUrl.fromLocalFile(path) url = QUrl.fromLocalFile(path)
@ -181,6 +182,7 @@ def fuzzy_url(urlstr, cwd=None, relative=False, do_search=True):
url = qurl_from_user_input(stripped) url = qurl_from_user_input(stripped)
log.url.debug("Converting fuzzy term {} to URL -> {}".format( log.url.debug("Converting fuzzy term {} to URL -> {}".format(
urlstr, url.toDisplayString())) urlstr, url.toDisplayString()))
if do_search and config.get('general', 'auto-search'): if do_search and config.get('general', 'auto-search'):
qtutils.ensure_valid(url) qtutils.ensure_valid(url)
else: else: