From cf1dc28214a94c187d124ca050ca262e3e2ab169 Mon Sep 17 00:00:00 2001 From: knaggita Date: Wed, 24 Aug 2016 16:12:32 +0300 Subject: [PATCH] Validate logger names passed to --logfilter --- qutebrowser/qutebrowser.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/qutebrowser/qutebrowser.py b/qutebrowser/qutebrowser.py index 2aa26ce15..6805fda58 100644 --- a/qutebrowser/qutebrowser.py +++ b/qutebrowser/qutebrowser.py @@ -140,12 +140,19 @@ def get_argparser(): return parser -def logfilter_error(logfilter): - if set(logfilter.split(',')).issubset(log.LOGGER_NAMES)==False: - raise argparse.ArgumentTypeError("filters: Invalid value {} - expected one " +def logfilter_error(logfilter: str): + """Validate logger names passed to --logfilter + + Args: + logfilter: A comma separated list of logger names. + """ + if set(logfilter.split(',')).issubset(log.LOGGER_NAMES): + return logfilter + else: + raise argparse.ArgumentTypeError( + "filters: Invalid value {} - expected one " "of: {}".format(logfilter, ', '.join(log.LOGGER_NAMES))) - return logfilter def main():