From cd95f94ac8287ce4a02d98a954d5bf5c9d4952b9 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 14 Jun 2016 18:35:28 +0200 Subject: [PATCH] Disallow None-callback for dump_async --- qutebrowser/browser/tab.py | 2 +- qutebrowser/browser/webengine/webenginetab.py | 2 +- qutebrowser/browser/webkit/webkittab.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/tab.py b/qutebrowser/browser/tab.py index 33d6bf8af..d9c6773aa 100644 --- a/qutebrowser/browser/tab.py +++ b/qutebrowser/browser/tab.py @@ -295,7 +295,7 @@ class AbstractTab(QWidget): def stop(self): raise NotImplementedError - def dump_async(self, callback=None, *, plain=False): + def dump_async(self, callback, *, plain=False): """Dump the current page to a file ascync. The given callback will be called with the result when dumping is diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 71f3de2f7..231d2175b 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -108,7 +108,7 @@ class WebEngineViewTab(tab.AbstractTab): def zoom_factor(self): return self._widget.zoomFactor() - def dump_async(self, callback=None, *, plain=False): + def dump_async(self, callback, *, plain=False): if plain: self._widget.page().toPlainText(callback) else: diff --git a/qutebrowser/browser/webkit/webkittab.py b/qutebrowser/browser/webkit/webkittab.py index bac2a2cfa..f19b7048e 100644 --- a/qutebrowser/browser/webkit/webkittab.py +++ b/qutebrowser/browser/webkit/webkittab.py @@ -371,7 +371,7 @@ class WebViewTab(tab.AbstractTab): def load_status(self): return self._widget.load_status - def dump_async(self, callback=None, *, plain=False): + def dump_async(self, callback, *, plain=False): frame = self._widget.page().mainFrame() if plain: callback(frame.toPlainText())