rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Initial pylint checker update

Browse Source
This commit is contained in:
Florian Bruhin 2017-06-14 11:44:18 +02:00
parent 3cee9cdcd7
commit cc90cc6843
1 changed files with 22 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
scripts/dev/pylint_checkers/qute_pylint/config.py
View File

@ -29,6 +29,9 @@ from pylint import interfaces, checkers
from pylint.checkers import utils from pylint.checkers import utils
OPTIONS = None
class ConfigChecker(checkers.BaseChecker): class ConfigChecker(checkers.BaseChecker):
"""Custom astroid checker for config calls.""" """Custom astroid checker for config calls."""
@ -36,47 +39,36 @@ class ConfigChecker(checkers.BaseChecker):
__implements__ = interfaces.IAstroidChecker __implements__ = interfaces.IAstroidChecker
name = 'config' name = 'config'
msgs = { msgs = {
'E0000': ('%s is no valid config option.', # flake8: disable=S001 'E9998': ('%s is no valid config option.', # flake8: disable=S001
'bad-config-call', 'bad-config-call',
None), None),
'E0001': ('old config call', # flake8: disable=S001 'E9999': ('old config call', # flake8: disable=S001
'old-config-call', 'old-config-call',
None), None),
} }
priority = -1 priority = -1
@utils.check_messages('bad-config-call') @utils.check_messages('bad-config-call')
def visit_call(self, node): def visit_attribute(self, node):
"""Visit a Call node.""" """Visit a getattr node."""
if hasattr(node, 'func'): # At the end of a config.val.foo.bar chain
infer = utils.safe_infer(node.func) if not isinstance(node.parent, astroid.Attribute):
if infer and infer.root().name == 'qutebrowser.config.config': # FIXME do some proper check for this...
if getattr(node.func, 'attrname', None) in ['get', 'set']: node_str = node.as_string()
self._check_config(node) prefix = 'config.val.'
if node_str.startswith(prefix):
self._check_config(node, node_str[len(prefix):])
def _check_config(self, node): def _check_config(self, node, name):
"""Check that the arguments to config.get(...) are valid.""" """Check that we're accessing proper config options."""
# try: if name not in OPTIONS:
# sect_arg = utils.get_argument_from_call(node, position=0, self.add_message('bad-config-call', node=node, args=name)
# keyword='sectname')
# opt_arg = utils.get_argument_from_call(node, position=1,
# keyword='optname')
# except utils.NoSuchArgumentError:
# return
# sect_arg = utils.safe_infer(sect_arg)
# opt_arg = utils.safe_infer(opt_arg)
# if not (isinstance(sect_arg, astroid.Const) and
# isinstance(opt_arg, astroid.Const)):
# return
# try:
# configdata.DATA[sect_arg.value][opt_arg.value]
# except KeyError:
# self.add_message('bad-config-call', node=node,
# args=(sect_arg.value, opt_arg.value))
self.add_message('old-config-call', node=node)
def register(linter): def register(linter):
"""Register this checker.""" """Register this checker."""
linter.register_checker(ConfigChecker(linter)) linter.register_checker(ConfigChecker(linter))
global OPTIONS
yaml_file = os.path.join('qutebrowser', 'config', 'configdata.yml')
with open(yaml_file, 'r', encoding='utf-8') as f:
OPTIONS = list(yaml.load(f))