From cbde36948ad096ad3691b8b5c06352486b6ac593 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 2 Feb 2015 06:53:55 +0100 Subject: [PATCH] Abort download override question on error/cancel. If a download error occured or the user cancelled the download during the file override question, an exception occured as the download was no longer valid when the question was answered. See #416. --- qutebrowser/browser/downloads.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/browser/downloads.py b/qutebrowser/browser/downloads.py index 283e5534f..0ed5a4dd3 100644 --- a/qutebrowser/browser/downloads.py +++ b/qutebrowser/browser/downloads.py @@ -276,6 +276,8 @@ class DownloadItem(QObject): q.answered_yes.connect(self._create_fileobj) q.answered_no.connect(functools.partial(self.cancel, False)) q.cancelled.connect(functools.partial(self.cancel, False)) + self.cancelled.connect(q.abort) + self.error.connect(q.abort) message_bridge = objreg.get('message-bridge', scope='window', window=self._win_id) message_bridge.ask(q, blocking=False)