From cbb9fd203a59e09d8d2f26bb02fc33fc8bb30878 Mon Sep 17 00:00:00 2001 From: Lamar Pavel Date: Thu, 5 Nov 2015 23:08:38 +0100 Subject: [PATCH] Fix test of existing metadata files In test_cache_existing_metadata_file() we are now getting the correct path to the metadata files, thus making the test useful. This was the last missing test, the cache is now 100% covered (issue#999). --- tests/unit/browser/test_cache.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/unit/browser/test_cache.py b/tests/unit/browser/test_cache.py index 6040c434b..b93add13d 100644 --- a/tests/unit/browser/test_cache.py +++ b/tests/unit/browser/test_cache.py @@ -136,10 +136,9 @@ def test_cache_existing_metadata_file(config_stub, tmpdir): disk_cache.insert(device) disk_cache.updateMetaData(metadata) - # TODO: Get path and name of file that device has been writing to - #fname = str(tmpdir) + "/cache_" + url + ".cache" - #assert disk_cache.fileMetaData(fname) == metadata - assert True + files = list(tmpdir.visit(fil=lambda path: path.isfile())) + assert len(files) == 1 + assert disk_cache.fileMetaData(str(files[0])) == metadata def test_cache_nonexistent_metadata_file(config_stub, tmpdir):