rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Allow download_stub test fixture to handle file targets.

Browse Source
This commit is contained in:
Jimmy 2018-01-02 15:56:28 +13:00
parent 2307a0850f
commit cba93954cd
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/unit/browser/test_adblock.py
View File

@ -23,12 +23,13 @@ import os.path
import zipfile import zipfile
import shutil import shutil
import logging import logging
import contextlib
import pytest import pytest
from PyQt5.QtCore import pyqtSignal, QUrl, QObject from PyQt5.QtCore import pyqtSignal, QUrl, QObject
from qutebrowser.browser import adblock from qutebrowser.browser import adblock, downloads
from qutebrowser.utils import objreg from qutebrowser.utils import objreg
pytestmark = pytest.mark.usefixtures('qapp', 'config_tmpdir') pytestmark = pytest.mark.usefixtures('qapp', 'config_tmpdir')
@ -89,14 +90,27 @@ class FakeDownloadManager:
def __init__(self, tmpdir): def __init__(self, tmpdir):
self._tmpdir = tmpdir self._tmpdir = tmpdir
@contextlib.contextmanager
def _open_fileobj(self, target):
"""Ensure a DownloadTarget's fileobj attribute is available."""
if isinstance(target, downloads.FileDownloadTarget):
target.fileobj = open(target.filename, 'wb')
try:
yield target.fileobj
finally:
target.fileobj.close()
else:
yield target.fileobj
def get(self, url, target, **kwargs): def get(self, url, target, **kwargs):
"""Return a FakeDownloadItem instance with a fileobj. """Return a FakeDownloadItem instance with a fileobj.
The content is copied from the file the given url links to. The content is copied from the file the given url links to.
""" """
download_item = FakeDownloadItem(target.fileobj, name=url.path()) with self._open_fileobj(target):
with (self._tmpdir / url.path()).open('rb') as fake_url_file: download_item = FakeDownloadItem(target.fileobj, name=url.path())
shutil.copyfileobj(fake_url_file, download_item.fileobj) with (self._tmpdir / url.path()).open('rb') as fake_url_file:
shutil.copyfileobj(fake_url_file, download_item.fileobj)
return download_item return download_item