rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix download redirections and :adblock-update.

Browse Source 
We called init_reply again which started read_timer even if the file object was
already set.

Fixes #294.
This commit is contained in:
Florian Bruhin 2014-12-01 07:40:36 +01:00
parent 316d5ff189
commit cb67198f7d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qutebrowser/browser/downloads.py
View File

@ -272,7 +272,8 @@ class DownloadItem(QObject):
reply.finished.connect(self.on_reply_finished)
reply.error.connect(self.on_reply_error)
reply.readyRead.connect(self.on_ready_read)
self._read_timer.start()
if not self.fileobj:
self._read_timer.start()
# We could have got signals before we connected slots to them.
# Here no signals are connected to the DownloadItem yet, so we use a
# singleShot QTimer to emit them after they are connected.
@ -367,7 +368,7 @@ class DownloadItem(QObject):
if self.reply.isFinished():
# Downloading to the buffer in RAM has already finished so we
# write out the data and clean up now.
self.finish_download()
self.on_reply_finished()
else:
# Since the buffer already might be full, on_ready_read might
# not be called at all anymore, so we force it here to flush