From c6deae36b1603fb24931232a49876f610cd356a3 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sat, 15 Nov 2014 20:06:39 +0100 Subject: [PATCH] Fix setting of successful flag. --- qutebrowser/browser/downloads.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/downloads.py b/qutebrowser/browser/downloads.py index 9ab69802a..6060fed88 100644 --- a/qutebrowser/browser/downloads.py +++ b/qutebrowser/browser/downloads.py @@ -117,7 +117,7 @@ class DownloadItem(QObject): if reply.error() != QNetworkReply.NoError: QTimer.singleShot(0, lambda: self.error.emit(reply.errorString())) if reply.isFinished(): - self.successful = reply.error() != QNetworkReply.NoError + self.successful = reply.error() == QNetworkReply.NoError QTimer.singleShot(0, self.finished.emit) self.timer = usertypes.Timer(self, 'speed_refresh') self.timer.timeout.connect(self.update_speed) @@ -293,9 +293,9 @@ class DownloadItem(QObject): self.fileobj.write(self._reply.readAll()) if self.autoclose: self.fileobj.close() + self.successful = self._reply.error() == QNetworkReply.NoError self._reply.close() self._reply.deleteLater() - self.successful = True self.finished.emit() log.downloads.debug("Download finished")