rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't place hints in invisible frames

Browse Source
This commit is contained in:
Florian Bruhin 2014-05-12 09:17:05 +02:00
parent dee97d6250
commit c61af3c805
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
qutebrowser/utils/webelem.py
View File

@ -67,21 +67,31 @@ def is_visible(elem):
Return: Return:
True if the element is visible, False otherwise. True if the element is visible, False otherwise.
""" """
# FIXME we should also check if the frame is visible
if elem.isNull(): if elem.isNull():
raise ValueError("Element is a null-element!") raise ValueError("Element is a null-element!")
frame = elem.webFrame() ## We're starting in the innermost (element) frame and check if every frame
## is visible in its parent.
base = elem.webFrame()
parent = base.parentFrame()
while parent is not None:
parentgeom = parent.geometry()
parentgeom.translate(parent.scrollPosition())
if not parentgeom.intersects(base.geometry()):
return False
base = parent
parent = parent.parentFrame()
rect = elem.geometry() rect = elem.geometry()
## Now check if the element is visible in the frame.
if (not rect.isValid()) and rect.x() == 0: if (not rect.isValid()) and rect.x() == 0:
# Most likely an invisible link # Most likely an invisible link
return False return False
frame = elem.webFrame()
framegeom = frame.geometry() framegeom = frame.geometry()
framegeom.moveTo(0, 0) framegeom.moveTo(0, 0)
framegeom.translate(frame.scrollPosition()) framegeom.translate(frame.scrollPosition())
if not framegeom.intersects(rect): if framegeom.intersects(rect):
# out of screen return True
return False return False
return True
def pos_on_screen(elem): def pos_on_screen(elem):