rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Handle background tabs in QtWebEngine createWindow with older Qt

Browse Source
This commit is contained in:
Florian Bruhin 2016-11-21 06:22:38 +01:00
parent d1154759d1
commit c5cacbc439
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/browser/webengine/webview.py
View File

@ -78,6 +78,13 @@ class WebEngineView(QWebEngineView):
log.webview.debug("createWindow with type {}, background_tabs " log.webview.debug("createWindow with type {}, background_tabs "
"{}".format(debug_type, background_tabs)) "{}".format(debug_type, background_tabs))
try:
background_tab_wintype = QWebEnginePage.WebBrowserBackgroundTab
except AttributeError:
# This is unavailable with an older PyQt, but we still might get
# this with a newer Qt...
background_tab_wintype = 0x0003
if wintype == QWebEnginePage.WebBrowserWindow: if wintype == QWebEnginePage.WebBrowserWindow:
# Shift-Alt-Click # Shift-Alt-Click
target = usertypes.ClickTarget.window target = usertypes.ClickTarget.window
@ -92,8 +99,7 @@ class WebEngineView(QWebEngineView):
target = usertypes.ClickTarget.tab target = usertypes.ClickTarget.tab
else: else:
target = usertypes.ClickTarget.tab_bg target = usertypes.ClickTarget.tab_bg
elif (hasattr(QWebEnginePage, 'WebBrowserBackgroundTab') and elif wintype == background_tab_wintype:
wintype == QWebEnginePage.WebBrowserBackgroundTab):
# Middle-click / Ctrl-Click # Middle-click / Ctrl-Click
if background_tabs: if background_tabs:
target = usertypes.ClickTarget.tab_bg target = usertypes.ClickTarget.tab_bg