Merge branch 'EliteTK-lowercase-toggle'

This commit is contained in:
Florian Bruhin 2016-06-08 22:40:05 +02:00
commit c5c022226f
4 changed files with 5 additions and 4 deletions

View File

@ -91,6 +91,7 @@ Fixed
- Fixed handling of backspace in number hinting mode
- Fixed `FileNotFoundError` when starting in some cases on old Qt versions
- Fixed sharing of cookies between tabs when `private-browsing` is enabled
- Toggling values with `:set` now uses lower-case values
v0.6.2
------

View File

@ -177,6 +177,7 @@ Contributors, sorted by the number of commits in descending order:
* Liam BEGUIN
* skinnay
* Zach-Button
* Tomasz Kramkowski
* Halfwit
* rikn00
* kanikaa1234
@ -188,7 +189,6 @@ Contributors, sorted by the number of commits in descending order:
* sbinix
* neeasade
* jnphilipp
* Tomasz Kramkowski
* Tobias Patzl
* Stefan Tatschner
* Peter Michely

View File

@ -734,7 +734,7 @@ class ConfigManager(QObject):
val = self.get(section_, option)
layer = 'temp' if temp else 'conf'
if isinstance(val, bool):
self.set(layer, section_, option, str(not val))
self.set(layer, section_, option, str(not val).lower())
else:
raise cmdexc.CommandError(
"set: Attempted inversion of non-boolean value.")

View File

@ -26,7 +26,7 @@ Feature: Setting settings.
Scenario: Toggling an option
When I run :set general auto-save-config false
And I run :set general auto-save-config!
Then general -> auto-save-config should be True
Then general -> auto-save-config should be true
Scenario: Toggling a non-bool option
When I run :set colors statusbar.bg!
@ -44,7 +44,7 @@ Feature: Setting settings.
Scenario: Using ! and -p
When I run :set general auto-save-config false
And I run :set -p general auto-save-config!
Then the message "general auto-save-config = True" should be shown
Then the message "general auto-save-config = true" should be shown
Scenario: Setting an invalid value
When I run :set general auto-save-config blah