From c308de95d1a2cfc17fbbae6341cd889988026413 Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Tue, 4 Nov 2014 21:06:50 +0100
Subject: [PATCH] Clean up tests

---
 qutebrowser/test/utils/test_split.py | 64 +++++++++-------------------
 1 file changed, 20 insertions(+), 44 deletions(-)

diff --git a/qutebrowser/test/utils/test_split.py b/qutebrowser/test/utils/test_split.py
index c0474425a..8880e13df 100644
--- a/qutebrowser/test/utils/test_split.py
+++ b/qutebrowser/test/utils/test_split.py
@@ -24,51 +24,27 @@ import unittest
 from qutebrowser.utils import split
 
 
+test_data = r"""
+one two|one|two|
+one "two three" four|one|two three|four|
+one 'two three' four|one|two three|four|
+one "two\" three" four|one|two" three|four|
+one 'two'\'' three' four|one|two' three|four|
+one "two three|one|two three|
+one 'two three|one|two three|
+one\|one\|
+one "two\|one|two\|
+"""
+
 class SplitTests(unittest.TestCase):
 
     """Test split."""
 
-    def test_normal(self):
-        """Test split with a simple string."""
-        items = split.split('one two')
-        self.assertEqual(items, ['one', 'two'])
-
-    def test_quoted(self):
-        """Test split with a normally quoted string."""
-        items = split.split('one "two three" four')
-        self.assertEqual(items, ['one', 'two three', 'four'])
-
-    def test_single_quoted(self):
-        """Test split with a single quoted string."""
-        items = split.split("one 'two three' four")
-        self.assertEqual(items, ['one', 'two three', 'four'])
-
-    def test_escaped(self):
-        """Test split with a normal escaped string."""
-        items = split.split(r'one "two\" three" four')
-        self.assertEqual(items, ['one', 'two" three', 'four'])
-
-    def test_escaped_single(self):
-        """Test split with a single escaped string."""
-        items = split.split(r"one 'two'\'' three' four")
-        self.assertEqual(items, ['one', "two' three", 'four'])
-
-    def test_unbalanced_quotes(self):
-        """Test split with unbalanded quotes."""
-        items = split.split(r'one "two three')
-        self.assertEqual(items, ['one', 'two three'])
-
-    def test_unbalanced_single_quotes(self):
-        """Test split with unbalanded single quotes."""
-        items = split.split(r"one 'two three")
-        self.assertEqual(items, ['one', "two three"])
-
-    def test_unfinished_escape(self):
-        """Test split with an unfinished escape."""
-        items = split.split('one\\')
-        self.assertEqual(items, ['one\\'])
-
-    def test_both(self):
-        """Test split with an unfinished escape and quotes.."""
-        items = split.split('one "two\\')
-        self.assertEqual(items, ['one', 'two\\'])
+    def test_split(self):
+        """Test splitting."""
+        for case in test_data.strip().splitlines():
+            cmd, *out = case.split('|')[:-1]
+            cmd = cmd.replace(r'\n', '\n')
+            with self.subTest(cmd=cmd):
+                items = split.split(cmd)
+                self.assertEqual(items, out)