rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix QTBUG-54419 workaround for invalid URLs

Browse Source
This commit is contained in:
Florian Bruhin 2016-11-26 13:32:37 +01:00
parent 73c608dce7
commit c17bbd47b8
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/mainwindow/tabbedbrowser.py
View File

@ -527,7 +527,7 @@ class TabbedBrowser(tabwidget.TabWidget):
background = self.currentIndex() != idx background = self.currentIndex() != idx
if (tab.backend == usertypes.Backend.QtWebEngine and if (tab.backend == usertypes.Backend.QtWebEngine and
tab.needs_qtbug54419_workaround): tab.needs_qtbug54419_workaround and url.isValid()):
log.misc.debug("Doing QTBUG-54419 workaround for {}, " log.misc.debug("Doing QTBUG-54419 workaround for {}, "
"url {}".format(tab, url)) "url {}".format(tab, url))
self.setUpdatesEnabled(False) self.setUpdatesEnabled(False)

5
tests/end2end/features/hints.feature
View File

@ -151,6 +151,11 @@ Feature: Using hints
And I hint with args "all" and follow a And I hint with args "all" and follow a
Then the error "Invalid link clicked - *" should be shown Then the error "Invalid link clicked - *" should be shown
Scenario: Clicking an invalid link opening in a new tab
When I open data/invalid_link.html
And I hint with args "all tab" and follow a
Then the error "Invalid link clicked - *" should be shown
Scenario: Hinting inputs without type Scenario: Hinting inputs without type
When I open data/hints/input.html When I open data/hints/input.html
And I hint with args "inputs" and follow a And I hint with args "inputs" and follow a