rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix bdd "Then" collision

Browse Source
This commit is contained in:
Florian Bruhin 2017-02-07 22:27:32 +01:00
parent 3f1433dcf7
commit bdcd980572
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/end2end/features/downloads.feature
View File

@ -111,7 +111,7 @@ Feature: Downloading things from a website.
And I wait for "fetch: * -> drip" in the log And I wait for "fetch: * -> drip" in the log
And I run :tab-close And I run :tab-close
And I wait for "Download drip finished" in the log And I wait for "Download drip finished" in the log
Then the downloaded file drip should contain 128 bytes Then the downloaded file drip should be 128 bytes big
Scenario: Downloading a file with spaces Scenario: Downloading a file with spaces
When I open data/downloads/download with spaces.bin without waiting When I open data/downloads/download with spaces.bin without waiting
@ -477,7 +477,7 @@ Feature: Downloading things from a website.
And I run :download http://localhost:(port)/data/downloads/download2.bin --dest download.bin And I run :download http://localhost:(port)/data/downloads/download2.bin --dest download.bin
And I wait for "Entering mode KeyMode.yesno *" in the log And I wait for "Entering mode KeyMode.yesno *" in the log
And I run :prompt-accept no And I run :prompt-accept no
Then the downloaded file download.bin should contain 1 bytes Then the downloaded file download.bin should be 1 bytes big
Scenario: Overwriting an existing file Scenario: Overwriting an existing file
When I set storage -> prompt-download-directory to false When I set storage -> prompt-download-directory to false
@ -487,7 +487,7 @@ Feature: Downloading things from a website.
And I wait for "Entering mode KeyMode.yesno *" in the log And I wait for "Entering mode KeyMode.yesno *" in the log
And I run :prompt-accept yes And I run :prompt-accept yes
And I wait until the download is finished And I wait until the download is finished
Then the downloaded file download.bin should contain 2 bytes Then the downloaded file download.bin should be 2 bytes big
@linux @linux
Scenario: Not overwriting a special file Scenario: Not overwriting a special file
@ -542,7 +542,7 @@ Feature: Downloading things from a website.
When I set storage -> prompt-download-directory to false When I set storage -> prompt-download-directory to false
And I run :download http://localhost:(port)/custom/twenty-mb And I run :download http://localhost:(port)/custom/twenty-mb
And I wait until the download is finished And I wait until the download is finished
Then the downloaded file twenty-mb should contain 20971520 bytes Then the downloaded file twenty-mb should be 20971520 bytes big
Scenario: Downloading 20MB file with late prompt confirmation Scenario: Downloading 20MB file with late prompt confirmation
When I set storage -> prompt-download-directory to true When I set storage -> prompt-download-directory to true
@ -550,7 +550,7 @@ Feature: Downloading things from a website.
And I wait 1s And I wait 1s
And I run :prompt-accept And I run :prompt-accept
And I wait until the download is finished And I wait until the download is finished
Then the downloaded file twenty-mb should contain 20971520 bytes Then the downloaded file twenty-mb should be 20971520 bytes big
Scenario: Downloading invalid URL Scenario: Downloading invalid URL
When I set storage -> prompt-download-directory to false When I set storage -> prompt-download-directory to false

4
tests/end2end/features/test_downloads_bdd.py
View File

@ -88,8 +88,8 @@ def download_should_exist(filename, tmpdir):
assert path.check() assert path.check()
@bdd.then(bdd.parsers.parse("The downloaded file {filename} should contain " @bdd.then(bdd.parsers.parse("The downloaded file {filename} should be "
"{size} bytes")) "{size} bytes big"))
def download_size(filename, size, tmpdir): def download_size(filename, size, tmpdir):
path = tmpdir / 'downloads' / filename path = tmpdir / 'downloads' / filename
assert path.size() == int(size) assert path.size() == int(size)