rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make an invalid download target fatal

Browse Source 
This should never happen, so there's no reason for it to log an error
instead of raising an exception.
This commit is contained in:
Florian Bruhin 2016-09-10 16:25:33 +02:00
parent b2d8905d68
commit bd5f63db46
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/browser/webkit/downloads.py
View File

@ -981,8 +981,8 @@ class DownloadManager(QAbstractListModel):
target.cmdline)) target.cmdline))
download.autoclose = True download.autoclose = True
download.set_fileobj(fobj) download.set_fileobj(fobj)
else: else: # pragma: no cover
log.downloads.error("Unknown download target: {}".format(target)) raise ValueError("Unknown download target: {}".format(target))
def _open_download(self, download, cmdline): def _open_download(self, download, cmdline):
"""Open the given download but only if it was successful. """Open the given download but only if it was successful.