rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pylint/openencoding: Fix checking of nonconst mode

Browse Source
This commit is contained in:
Florian Bruhin 2015-03-08 22:31:29 +01:00
parent 181bcc4f8d
commit bd3d091318
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/pylint_checkers/openencoding.py
View File

@ -62,10 +62,16 @@ class OpenEncodingChecker(checkers.BaseChecker):
except utils.NoSuchArgumentError: except utils.NoSuchArgumentError:
pass pass
if _encoding is None: if _encoding is None:
if mode_arg is not None: if mode_arg is None:
mode = None
else:
mode = utils.safe_infer(mode_arg) mode = utils.safe_infer(mode_arg)
if (mode_arg is not None and isinstance(mode, astroid.Const) and if mode is not None and not isinstance(mode, astroid.Const):
'b' in getattr(mode, 'value', '')): # We can't say what mode is exactly.
return
if mode is None:
self.add_message('open-without-encoding', node=node)
elif 'b' in getattr(mode, 'value', ''):
# Files opened as binary don't need an encoding. # Files opened as binary don't need an encoding.
return return
else: else: