rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Blacklist some modes for :enter-mode

Browse Source 
This disallows using :enter-mode with modes that don't work properly
when entered that way. Fixes #1137.
This commit is contained in:
Jan Verbeek 2017-01-20 19:32:16 +01:00
parent 3584eabd6f
commit bd3c2f92fc
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/keyinput/modeman.py
View File

@ -265,6 +265,10 @@ class ModeManager(QObject):
m = usertypes.KeyMode[mode] m = usertypes.KeyMode[mode]
except KeyError: except KeyError:
raise cmdexc.CommandError("Mode {} does not exist!".format(mode)) raise cmdexc.CommandError("Mode {} does not exist!".format(mode))
if m in [usertypes.KeyMode.hint, usertypes.KeyMode.command,
usertypes.KeyMode.yesno, usertypes.KeyMode.prompt]:
raise cmdexc.CommandError(
"Mode {} can't be entered manually!".format(mode))
self.enter(m, 'command') self.enter(m, 'command')
@pyqtSlot(usertypes.KeyMode, str, bool) @pyqtSlot(usertypes.KeyMode, str, bool)

6
tests/end2end/features/misc.feature
View File

@ -642,3 +642,9 @@ Feature: Various utility commands.
And I run :command-accept And I run :command-accept
And I set general -> private-browsing to false And I set general -> private-browsing to false
Then the message "blah" should be shown Then the message "blah" should be shown
## Modes blacklisted for :enter-mode
Scenario: Trying to enter command mode with :enter-mode
When I run :enter-mode command
Then the error "Mode command can't be entered manually!" should be shown