rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tests: Avoid race conditions for :messages tests

Browse Source 
We need to wait until the page is actually loaded before we check the
content.
This commit is contained in:
Florian Bruhin 2016-05-29 17:07:37 +02:00
parent 6f6303e0a6
commit bceb7cf89e
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration/features/misc.feature
View File

@ -387,7 +387,8 @@ Feature: Various utility commands.
And I run :message-warning the-warning-message And I run :message-warning the-warning-message
And I run :message-info the-info-message And I run :message-info the-info-message
And I run :messages And I run :messages
Then the error "the-error-message" should be shown Then qute://log?level=error should be loaded
And the error "the-error-message" should be shown
And the warning "the-warning-message" should be shown And the warning "the-warning-message" should be shown
And the page should contain the plaintext "the-error-message" And the page should contain the plaintext "the-error-message"
And the page should not contain the plaintext "the-warning-message" And the page should not contain the plaintext "the-warning-message"
@ -398,7 +399,8 @@ Feature: Various utility commands.
And I run :message-warning the-warning-message And I run :message-warning the-warning-message
And I run :message-info the-info-message And I run :message-info the-info-message
And I run :messages warning And I run :messages warning
Then the error "the-error-message" should be shown Then qute://log?level=warning should be loaded
And the error "the-error-message" should be shown
And the warning "the-warning-message" should be shown And the warning "the-warning-message" should be shown
And the page should contain the plaintext "the-error-message" And the page should contain the plaintext "the-error-message"
And the page should contain the plaintext "the-warning-message" And the page should contain the plaintext "the-warning-message"
@ -409,7 +411,8 @@ Feature: Various utility commands.
And I run :message-warning the-warning-message And I run :message-warning the-warning-message
And I run :message-info the-info-message And I run :message-info the-info-message
And I run :messages info And I run :messages info
Then the error "the-error-message" should be shown Then qute://log?level=info should be loaded
And the error "the-error-message" should be shown
And the warning "the-warning-message" should be shown And the warning "the-warning-message" should be shown
And the page should contain the plaintext "the-error-message" And the page should contain the plaintext "the-error-message"
And the page should contain the plaintext "the-warning-message" And the page should contain the plaintext "the-warning-message"
@ -430,7 +433,8 @@ Feature: Various utility commands.
Scenario: Using :messages without messages Scenario: Using :messages without messages
Given I have a fresh instance Given I have a fresh instance
When I run :messages When I run :messages
Then the page should contain the plaintext "No messages to show." Then qute://log?level=error should be loaded
And the page should contain the plaintext "No messages to show."
## https://github.com/The-Compiler/qutebrowser/issues/1523 ## https://github.com/The-Compiler/qutebrowser/issues/1523