From bcd512092282b56eacd1da2bcd1d0c69933614dc Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 21 Feb 2014 07:33:32 +0100 Subject: [PATCH] FIXME: Only destroy replies when they're not special. Why does a normal destroy not work? --- qutebrowser/network/networkmanager.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qutebrowser/network/networkmanager.py b/qutebrowser/network/networkmanager.py index 30d866fc3..c8f2bd547 100644 --- a/qutebrowser/network/networkmanager.py +++ b/qutebrowser/network/networkmanager.py @@ -68,8 +68,8 @@ class NetworkManager(QNetworkAccessManager): if scheme in self._scheme_handlers: reply = self._scheme_handlers[scheme].createRequest( op, req, outgoing_data) - return reply - reply = super().createRequest(op, req, outgoing_data) - self._requests[id(reply)] = reply - reply.destroyed.connect(lambda obj: self._requests.pop(id(obj))) + else: + reply = super().createRequest(op, req, outgoing_data) + self._requests[id(reply)] = reply + reply.destroyed.connect(lambda obj: self._requests.pop(id(obj))) return reply