From bc009ef462385fa5dcd125dfc85a4873d4816873 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 5 Aug 2014 21:06:32 +0200 Subject: [PATCH] conftypes: Check URL for SearchEngineUrl. --- qutebrowser/config/conftypes.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qutebrowser/config/conftypes.py b/qutebrowser/config/conftypes.py index 878acdf7b..015a2da77 100644 --- a/qutebrowser/config/conftypes.py +++ b/qutebrowser/config/conftypes.py @@ -1025,10 +1025,12 @@ class SearchEngineUrl(BaseType): return else: raise ValidationError(value, "may not be empty!") - if '{}' in value: - pass - else: + if '{}' not in value: raise ValidationError(value, "must contain \"{}\"") + url = QUrl(value.replace('{}', 'foobar')) + if not url.isValid(): + raise ValidationError(value, "invalid url, {}".format( + url.errorString())) class KeyBindingName(BaseType):