diff --git a/qutebrowser/config/config.py b/qutebrowser/config/config.py index b05936473..baeaf8307 100644 --- a/qutebrowser/config/config.py +++ b/qutebrowser/config/config.py @@ -24,7 +24,7 @@ import contextlib import functools from PyQt5.QtCore import pyqtSignal, pyqtSlot, QObject, QUrl -from PyQt5.QtWidgets import QApplication, QMessageBox +from PyQt5.QtWidgets import QMessageBox from qutebrowser.config import configdata, configexc, configtypes, configfiles from qutebrowser.utils import utils, objreg, message, log, usertypes diff --git a/qutebrowser/config/configexc.py b/qutebrowser/config/configexc.py index a5332fe6e..b81461dfa 100644 --- a/qutebrowser/config/configexc.py +++ b/qutebrowser/config/configexc.py @@ -98,6 +98,7 @@ class ConfigFileErrors(Error): self.errors = errors def to_html(self): + """Get the error texts as a HTML snippet.""" from qutebrowser.utils import jinja template = jinja.environment.from_string(""" Errors occurred while reading {{ basename }}: diff --git a/qutebrowser/config/configfiles.py b/qutebrowser/config/configfiles.py index e72919736..e7ca548f7 100644 --- a/qutebrowser/config/configfiles.py +++ b/qutebrowser/config/configfiles.py @@ -126,7 +126,7 @@ class ConfigAPI: self.errors.append(configexc.ConfigErrorDesc(text, e)) def finalize(self): - """Needs to get called after reading config.py is done.""" + """Do work which needs to be done after reading config.py.""" self._config.update_mutables() def get(self, name): diff --git a/qutebrowser/utils/error.py b/qutebrowser/utils/error.py index 7b62d8146..0d045bf19 100644 --- a/qutebrowser/utils/error.py +++ b/qutebrowser/utils/error.py @@ -19,7 +19,6 @@ """Tools related to error printing/displaying.""" -from PyQt5.QtCore import Qt from PyQt5.QtWidgets import QMessageBox from qutebrowser.utils import log, utils diff --git a/scripts/dev/run_vulture.py b/scripts/dev/run_vulture.py index 5e31d0b8f..fd16a656c 100755 --- a/scripts/dev/run_vulture.py +++ b/scripts/dev/run_vulture.py @@ -105,6 +105,9 @@ def whitelist_generator(): for name, member in inspect.getmembers(configtypes, inspect.isclass): yield 'qutebrowser.config.configtypes.' + name + yield 'qutebrowser.config.configexc.ConfigErrorDesc.traceback' + yield 'qutebrowser.config.configfiles.ConfigAPI.load_autoconfig' + yield 'types.ModuleType.c' # configfiles:read_config_py yield 'include_aliases' ## FIXME:conf TODO