From bb2caaa11ddcdcff58e8a3e85b66da1a7b9f305a Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 27 Feb 2015 18:47:53 +0100 Subject: [PATCH] Suppress Qt warning in unittests. --- qutebrowser/test/browser/test_tabhistory.py | 4 +++- qutebrowser/test/helpers.py | 11 +++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/qutebrowser/test/browser/test_tabhistory.py b/qutebrowser/test/browser/test_tabhistory.py index 9e1b516d0..8fc64c8b9 100644 --- a/qutebrowser/test/browser/test_tabhistory.py +++ b/qutebrowser/test/browser/test_tabhistory.py @@ -27,6 +27,7 @@ from PyQt5.QtWebKitWidgets import QWebPage from qutebrowser.browser import tabhistory from qutebrowser.browser.tabhistory import TabHistoryItem as Item from qutebrowser.utils import qtutils +from qutebrowser.test import helpers class SerializeHistoryTests(unittest.TestCase): @@ -61,7 +62,8 @@ class SerializeHistoryTests(unittest.TestCase): def test_count(self): """Check if the history's count was loaded correctly.""" - self.assertEqual(self.history.count(), len(self.items)) + with helpers.disable_logger('qt'): + self.assertEqual(self.history.count(), len(self.items)) def test_valid(self): """Check if all items are valid.""" diff --git a/qutebrowser/test/helpers.py b/qutebrowser/test/helpers.py index b5c6b0dd7..8c8fb8cef 100644 --- a/qutebrowser/test/helpers.py +++ b/qutebrowser/test/helpers.py @@ -20,6 +20,7 @@ """Helpers needed by tests.""" import os +import logging import contextlib from unittest import mock @@ -55,6 +56,16 @@ def environ_set_temp(env): del os.environ[name] +@contextlib.contextmanager +def disable_logger(name): + """Temporarily disable a logger.""" + logging.getLogger(name).propagate = False + try: + yield + finally: + logging.getLogger(name).propagate = True + + def fake_keyevent(key, modifiers=0, text=''): """Generate a new fake QKeyPressEvent.""" evtmock = mock.create_autospec(QKeyEvent, instance=True)