rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'blyxxyz-strip-mailto'

Browse Source
This commit is contained in:
Florian Bruhin 2017-02-04 17:49:41 +01:00
commit b988c9d1cb
5 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.asciidoc
View File

@ -27,6 +27,7 @@ Changed
- Scrolling with the scrollwheel while holding shift now scrolls sideways - Scrolling with the scrollwheel while holding shift now scrolls sideways
- New way of clicking hints with which solves various small issues - New way of clicking hints with which solves various small issues
- When yanking a mailto: link via hints, the mailto: prefix is now stripped
Fixed Fixed
----- -----

2
README.asciidoc
View File

@ -146,8 +146,8 @@ Contributors, sorted by the number of commits in descending order:
* Florian Bruhin * Florian Bruhin
* Daniel Schadt * Daniel Schadt
* Ryan Roden-Corrent * Ryan Roden-Corrent
* Jakub Klinkovský
* Jan Verbeek * Jan Verbeek
* Jakub Klinkovský
* Antoni Boucher * Antoni Boucher
* Lamar Pavel * Lamar Pavel
* Marshall Lochbaum * Marshall Lochbaum

5
qutebrowser/browser/hints.py
View File

@ -235,7 +235,10 @@ class HintActions:
sel = (context.target == Target.yank_primary and sel = (context.target == Target.yank_primary and
utils.supports_selection()) utils.supports_selection())
urlstr = url.toString(QUrl.FullyEncoded | QUrl.RemovePassword) flags = QUrl.FullyEncoded | QUrl.RemovePassword
if url.scheme() == 'mailto':
flags |= QUrl.RemoveScheme
urlstr = url.toString(flags)
utils.set_clipboard(urlstr, selection=sel) utils.set_clipboard(urlstr, selection=sel)
msg = "Yanked URL to {}: {}".format( msg = "Yanked URL to {}: {}".format(

11
tests/end2end/data/email_address.html Normal file
View File

@ -0,0 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Email address</title>
</head>
<body>
<a href="mailto:nobody">Email address</a>
</body>
</html>

6
tests/end2end/features/hints.feature
View File

@ -99,6 +99,12 @@ Feature: Using hints
And I hint with args "links yank-primary" and follow a And I hint with args "links yank-primary" and follow a
Then the clipboard should contain "http://localhost:(port)/data/hello.txt" Then the clipboard should contain "http://localhost:(port)/data/hello.txt"
Scenario: Yanking email address to clipboard
When I run :debug-set-fake-clipboard
And I open data/email_address.html
And I hint with args "links yank" and follow a
Then the clipboard should contain "nobody"
Scenario: Rapid hinting Scenario: Rapid hinting
When I open data/hints/rapid.html in a new tab When I open data/hints/rapid.html in a new tab
And I run :tab-only And I run :tab-only