rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Enable errors on renderer process crashes

Browse Source
This commit is contained in:
Florian Bruhin 2017-02-06 17:55:54 +01:00
parent 52e3865367
commit b8b4611b4d
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
qutebrowser/browser/webengine/webenginetab.py
View File

@ -40,7 +40,7 @@ from qutebrowser.browser.webengine import (webview, webengineelem, tabhistory,
webenginedownloads) webenginedownloads)
from qutebrowser.misc import miscwidgets from qutebrowser.misc import miscwidgets
from qutebrowser.utils import (usertypes, qtutils, log, javascript, utils, from qutebrowser.utils import (usertypes, qtutils, log, javascript, utils,
objreg, jinja) objreg, jinja, message)
_qute_scheme_handler = None _qute_scheme_handler = None
@ -663,6 +663,21 @@ class WebEngineTab(browsertab.AbstractTab):
notification.show() notification.show()
notification.set_timeout(3000) notification.set_timeout(3000)
@pyqtSlot(QWebEnginePage.RenderProcessTerminationStatus, int)
def _on_render_process_terminated(self, status, exitcode):
"""Show an error when the renderer process terminated."""
if status == QWebEnginePage.NormalTerminationStatus:
pass
elif status == QWebEnginePage.AbnormalTerminationStatus:
message.error("Renderer process exited with status {}".format(
exitcode))
elif status == QWebEnginePage.CrashedTerminationStatus:
message.error("Renderer process crashed")
elif status == QWebEnginePage.KilledTerminationStatus:
message.error("Renderer process was killed")
else:
raise ValueError("Invalid status {}".format(status))
def _connect_signals(self): def _connect_signals(self):
view = self._widget view = self._widget
page = view.page() page = view.page()
@ -677,17 +692,19 @@ class WebEngineTab(browsertab.AbstractTab):
page.certificate_error.connect(self._on_ssl_errors) page.certificate_error.connect(self._on_ssl_errors)
page.authenticationRequired.connect(self._on_authentication_required) page.authenticationRequired.connect(self._on_authentication_required)
page.fullScreenRequested.connect(self._on_fullscreen_requested) page.fullScreenRequested.connect(self._on_fullscreen_requested)
view.titleChanged.connect(self.title_changed)
view.urlChanged.connect(self._on_url_changed)
try:
view.iconChanged.connect(self.icon_changed)
except AttributeError:
log.stub('iconChanged, on Qt < 5.7')
try: try:
page.contentsSizeChanged.connect(self.contents_size_changed) page.contentsSizeChanged.connect(self.contents_size_changed)
except AttributeError: except AttributeError:
log.stub('contentsSizeChanged, on Qt < 5.7') log.stub('contentsSizeChanged, on Qt < 5.7')
view.titleChanged.connect(self.title_changed)
view.urlChanged.connect(self._on_url_changed)
view.renderProcessTerminated.connect(
self._on_render_process_terminated)
try:
view.iconChanged.connect(self.icon_changed)
except AttributeError:
log.stub('iconChanged, on Qt < 5.7')
def event_target(self): def event_target(self):
return self._widget.focusProxy() return self._widget.focusProxy()