rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add tests for suppressing debug log records.

Browse Source 
For the LogFilter tests I just copied some of the examples that were
already being used and reversed them. To do that without even more
duplication I had to add another parameter to the test.
This commit is contained in:
Jimmy 2018-06-11 21:28:13 +12:00
parent addd2e74ce
commit b7929ef747
1 changed files with 42 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
tests/unit/utils/test_log.py
View File

@ -116,24 +116,36 @@ class TestLogFilter:
return logger.makeRecord(name, level=level, fn=None, lno=0, msg="", return logger.makeRecord(name, level=level, fn=None, lno=0, msg="",
args=None, exc_info=None) args=None, exc_info=None)
@pytest.mark.parametrize('filters, category, logged', [ @pytest.mark.parametrize('filters, negated, category, logged', [
# Filter letting all messages through # Filter letting all messages through
(None, 'eggs.bacon.spam', True), (None, False, 'eggs.bacon.spam', True),
(None, 'eggs', True), (None, False, 'eggs', True),
(None, True, 'ham', True),
# Matching records # Matching records
(['eggs', 'bacon'], 'eggs', True), (['eggs', 'bacon'], False, 'eggs', True),
(['eggs', 'bacon'], 'bacon', True), (['eggs', 'bacon'], False, 'bacon', True),
(['eggs.bacon'], 'eggs.bacon', True), (['eggs.bacon'], False, 'eggs.bacon', True),
# Non-matching records # Non-matching records
(['eggs', 'bacon'], 'spam', False), (['eggs', 'bacon'], False, 'spam', False),
(['eggs'], 'eggsauce', False), (['eggs'], False, 'eggsauce', False),
(['eggs.bacon'], 'eggs.baconstrips', False), (['eggs.bacon'], False, 'eggs.baconstrips', False),
# Child loggers # Child loggers
(['eggs.bacon', 'spam.ham'], 'eggs.bacon.spam', True), (['eggs.bacon', 'spam.ham'], False, 'eggs.bacon.spam', True),
(['eggs.bacon', 'spam.ham'], 'spam.ham.salami', True), (['eggs.bacon', 'spam.ham'], False, 'spam.ham.salami', True),
# Suppressed records
(['eggs', 'bacon'], True, 'eggs', False),
(['eggs', 'bacon'], True, 'bacon', False),
(['eggs.bacon'], True, 'eggs.bacon', False),
# Non-suppressed records
(['eggs', 'bacon'], True, 'spam', True),
(['eggs'], True, 'eggsauce', True),
(['eggs.bacon'], True, 'eggs.baconstrips', True),
]) ])
def test_logfilter(self, logger, filters, category, logged): def test_logfilter(self, logger, filters, negated, category, logged):
logfilter = log.LogFilter(filters) """
Check the multi-record filtering filterer filters multiple records.
"""
logfilter = log.LogFilter(filters, negated)
record = self._make_record(logger, category) record = self._make_record(logger, category)
assert logfilter.filter(record) == logged assert logfilter.filter(record) == logged
@ -204,6 +216,23 @@ class TestInitLog:
log.init_log(args) log.init_log(args)
sys.stderr = old_stderr sys.stderr = old_stderr
@pytest.mark.parametrize('logfilter, negated', [
('!one,two', True),
('one,two', False),
('one,!two', False),
(None, False),
])
def test_negation_parser(self, args, mocker, logfilter, negated):
"""Test parsing the --logfilter argument."""
filter_mock = mocker.patch('qutebrowser.utils.log.LogFilter',
autospec=True)
args.logfilter = logfilter
log.init_log(args)
expected_names = (logfilter.lstrip('!').split(',') if logfilter else
None)
assert filter_mock.called
assert filter_mock.call_args[0] == (expected_names, negated)
class TestHideQtWarning: class TestHideQtWarning: