diff --git a/qutebrowser/browser/webkit/cache.py b/qutebrowser/browser/webkit/cache.py index 78f459e3f..349f9a61e 100644 --- a/qutebrowser/browser/webkit/cache.py +++ b/qutebrowser/browser/webkit/cache.py @@ -54,7 +54,7 @@ class DiskCache(QNetworkDiskCache): if size is None: size = 1024 * 1024 * 50 # default from QNetworkDiskCachePrivate # WORKAROUND for https://github.com/qutebrowser/qutebrowser/issues/2427 - if qtutils.version_check('5.8', exact=True): + if qtutils.version_check('5.8', exact=True): # pragma: no cover size = 0 self.setMaximumCacheSize(size) diff --git a/tests/unit/browser/webkit/test_cache.py b/tests/unit/browser/webkit/test_cache.py index c716b9b82..7e2164b9c 100644 --- a/tests/unit/browser/webkit/test_cache.py +++ b/tests/unit/browser/webkit/test_cache.py @@ -17,10 +17,16 @@ # You should have received a copy of the GNU General Public License # along with qutebrowser. If not, see . +import pytest from PyQt5.QtCore import QUrl, QDateTime from PyQt5.QtNetwork import QNetworkDiskCache, QNetworkCacheMetaData from qutebrowser.browser.webkit import cache +from qutebrowser.utils import qtutils + + +pytestmark = pytest.mark.skipif(qtutils.version_check('5.8', exact=True), + reason="QNetworkDiskCache is broken on Qt 5.8") def preload_cache(cache, url='http://www.example.com/', content=b'foobar'):