From 199f0aeb76ceb18dafbf5db59f19937f1af9850b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Klinkovsk=C3=BD?= Date: Mon, 6 Jun 2016 17:26:09 +0200 Subject: [PATCH 1/2] tests: un-xfail some iframe tests (#1525) The given reason (clicking an iframe to get a focus) applies to only one test, the others are either stable or flaky for a different reason. --- tests/end2end/features/hints.feature | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/end2end/features/hints.feature b/tests/end2end/features/hints.feature index 5bccf7ab4..c76f96d82 100644 --- a/tests/end2end/features/hints.feature +++ b/tests/end2end/features/hints.feature @@ -108,15 +108,14 @@ Feature: Using hints And the javascript message "boop!" should be logged ### iframes - ### FIXME currenly skipped, see https://github.com/The-Compiler/qutebrowser/issues/1525 - @xfail_norun Scenario: Using :follow-hint inside an iframe When I open data/hints/iframe.html And I run :hint links normal And I run :follow-hint a Then "acceptNavigationRequest, url http://localhost:*/data/hello.txt, type NavigationTypeLinkClicked, *" should be logged + ### FIXME currenly skipped, see https://github.com/The-Compiler/qutebrowser/issues/1525 @xfail_norun Scenario: Using :follow-hint inside a scrolled iframe When I open data/hints/iframe_scroll.html @@ -127,14 +126,12 @@ Feature: Using hints And I run :follow-hint a Then "acceptNavigationRequest, url http://localhost:*/data/hello2.txt, type NavigationTypeLinkClicked, *" should be logged - @xfail_norun Scenario: Opening a link inside a specific iframe When I open data/hints/iframe_target.html And I run :hint links normal And I run :follow-hint a Then "acceptNavigationRequest, url http://localhost:*/data/hello.txt, type NavigationTypeLinkClicked, *" should be logged - @xfail_norun Scenario: Opening a link with specific target frame in a new tab When I open data/hints/iframe_target.html And I run :hint links tab From b1997c1e00ef09b56ca5077cb56b9be77c5ff373 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Klinkovsk=C3=BD?= Date: Mon, 6 Jun 2016 18:26:04 +0200 Subject: [PATCH 2/2] tests: add missing wait in "Scenario: Opening a link with specific target frame in a new tab" --- tests/end2end/features/hints.feature | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/end2end/features/hints.feature b/tests/end2end/features/hints.feature index c76f96d82..149f4d327 100644 --- a/tests/end2end/features/hints.feature +++ b/tests/end2end/features/hints.feature @@ -136,6 +136,7 @@ Feature: Using hints When I open data/hints/iframe_target.html And I run :hint links tab And I run :follow-hint a + And I wait until data/hello.txt is loaded Then the following tabs should be open: - data/hints/iframe_target.html - data/hello.txt (active)