rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tests: Add some "# pragma: no cover" for downloads

Browse Source
This commit is contained in:
Florian Bruhin 2016-04-05 11:43:01 +02:00
parent ebee06a9c4
commit b5c177526c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/browser/downloads.py
View File

@ -90,7 +90,7 @@ def path_suggestion(filename):
return filename return filename
elif suggestion == 'both': elif suggestion == 'both':
return os.path.join(download_dir(), filename) return os.path.join(download_dir(), filename)
else: else: # pragma: no cover
raise ValueError("Invalid suggestion value {}!".format(suggestion)) raise ValueError("Invalid suggestion value {}!".format(suggestion))
@ -518,7 +518,7 @@ class DownloadItem(QObject):
None: special value to stop the download. None: special value to stop the download.
""" """
global last_used_directory global last_used_directory
if self.fileobj is not None: if self.fileobj is not None: # pragma: no cover
raise ValueError("fileobj was already set! filename: {}, " raise ValueError("fileobj was already set! filename: {}, "
"existing: {}, fileobj {}".format( "existing: {}, fileobj {}".format(
filename, self._filename, self.fileobj)) filename, self._filename, self.fileobj))
@ -575,7 +575,7 @@ class DownloadItem(QObject):
Args: Args:
fileobj: A file-like object. fileobj: A file-like object.
""" """
if self.fileobj is not None: if self.fileobj is not None: # pragma: no cover
raise ValueError("fileobj was already set! Old: {}, new: " raise ValueError("fileobj was already set! Old: {}, new: "
"{}".format(self.fileobj, fileobj)) "{}".format(self.fileobj, fileobj))
self.fileobj = fileobj self.fileobj = fileobj
@ -785,7 +785,7 @@ class DownloadManager(QAbstractListModel):
If not, None. If not, None.
""" """
if fileobj is not None and filename is not None: if fileobj is not None and filename is not None: # pragma: no cover
raise TypeError("Only one of fileobj/filename may be given!") raise TypeError("Only one of fileobj/filename may be given!")
# WORKAROUND for Qt corrupting data loaded from cache: # WORKAROUND for Qt corrupting data loaded from cache:
# https://bugreports.qt.io/browse/QTBUG-42757 # https://bugreports.qt.io/browse/QTBUG-42757
@ -869,7 +869,7 @@ class DownloadManager(QAbstractListModel):
Return: Return:
The created DownloadItem. The created DownloadItem.
""" """
if fileobj is not None and filename is not None: if fileobj is not None and filename is not None: # pragma: no cover
raise TypeError("Only one of fileobj/filename may be given!") raise TypeError("Only one of fileobj/filename may be given!")
if not suggested_filename: if not suggested_filename:
if filename is not None: if filename is not None: