rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix crashes with downloads in a closed tab.

Browse Source 
When a download was redirected or failed after a tab was closed, there was a
KeyError in the object registry.

Fixes #889. This is a regression introduced in
976f758da1 / #731.
This commit is contained in:
Florian Bruhin 2015-11-09 07:46:22 +01:00
parent 89c0ff0d9b
commit b59a56921e
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
qutebrowser/browser/network/networkmanager.py
View File

@ -363,8 +363,13 @@ class NetworkManager(QNetworkAccessManager):
if self._tab_id is None: if self._tab_id is None:
current_url = QUrl() # generic NetworkManager, e.g. for downloads current_url = QUrl() # generic NetworkManager, e.g. for downloads
else: else:
webview = objreg.get('webview', scope='tab', window=self._win_id, try:
tab=self._tab_id) webview = objreg.get('webview', scope='tab',
window=self._win_id, tab=self._tab_id)
except KeyError:
# https://github.com/The-Compiler/qutebrowser/issues/889
current_url = QUrl()
else:
current_url = webview.url() current_url = webview.url()
self.set_referer(req, current_url) self.set_referer(req, current_url)