From b40a1bfb83472048df9ae4a05f1f43a0b34aba24 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 5 Feb 2017 12:33:40 +0100 Subject: [PATCH] Disable percent-decoding for QtWebEngine with Qt >= 5.8.1 --- qutebrowser/browser/webengine/webenginedownloads.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginedownloads.py b/qutebrowser/browser/webengine/webenginedownloads.py index 2baf27541..a9b6ac336 100644 --- a/qutebrowser/browser/webengine/webenginedownloads.py +++ b/qutebrowser/browser/webengine/webenginedownloads.py @@ -137,10 +137,12 @@ def _get_suggested_filename(path): """ filename = os.path.basename(path) filename = re.sub(r'\([0-9]+\)$', '', filename) - # https://bugreports.qt.io/browse/QTBUG-58155 - filename = urllib.parse.unquote(filename) - # Doing basename a *second* time because there could be a %2F in there... - filename = os.path.basename(filename) + if not qtutils.version_check('5.8.1'): + # https://bugreports.qt.io/browse/QTBUG-58155 + filename = urllib.parse.unquote(filename) + # Doing basename a *second* time because there could be a %2F in + # there... + filename = os.path.basename(filename) return filename