From aefa637bc58f2bacd2702c73edff499bb0afd6e8 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 11 Dec 2014 22:16:56 +0100 Subject: [PATCH] Check if command text is valid when hinting. --- qutebrowser/browser/hints.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 1717cc7ef..5f588db17 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -30,7 +30,7 @@ from PyQt5.QtWidgets import QApplication from PyQt5.QtWebKit import QWebElement from qutebrowser.config import config -from qutebrowser.keyinput import modeman +from qutebrowser.keyinput import modeman, modeparsers from qutebrowser.browser import webelem from qutebrowser.commands import userscripts, cmdexc, cmdutils from qutebrowser.utils import usertypes, log, qtutils, message, objreg @@ -401,7 +401,13 @@ class HintManager(QObject): """ urlstr = url.toDisplayString(QUrl.FullyEncoded) args = context.get_args(urlstr) - message.set_cmd_text(self._win_id, ' '.join(args)) + text = ' '.join(args) + if text[0] not in modeparsers.STARTCHARS: + message.error(self._win_id, + "Invalid command text '{}'.".format(text), + immediately=True) + else: + message.set_cmd_text(self._win_id, text) def _download(self, elem, context): """Download a hint URL.