Small fixes for marks.

Mark two callbacks with pyqtSlot as appropriate.
Return False instead of raising NotImplementedException to avoid pylint
identifying MarkKeyParser as abstract.
This commit is contained in:
Ryan Roden-Corrent 2016-04-19 07:50:59 -04:00
parent c7ee7a9702
commit ae267c466f
2 changed files with 3 additions and 1 deletions

View File

@ -279,10 +279,11 @@ class MarkKeyParser(keyparser.BaseKeyParser):
return True
@pyqtSlot(str)
def on_keyconfig_changed(self, mode):
"""MarkKeyParser has no config section (no bindable keys)."""
pass
def execute(self, cmdstr, _keytype, count=None):
"""Should never be called on MarkKeyParser."""
raise NotImplementedError
assert False

View File

@ -673,6 +673,7 @@ class TabbedBrowser(tabwidget.TabWidget):
if key.isupper() and key in self._global_marks:
point, url = self._global_marks[key]
@pyqtSlot(bool)
def callback(ok):
if ok:
self.cur_load_finished.disconnect(callback)