From adf2f9860de1879db4b45c4f9d9307d675702052 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 3 May 2018 17:58:56 +0200 Subject: [PATCH] Disable spellcheck when it's unneeded. Fixes #3753 --- doc/changelog.asciidoc | 3 +++ qutebrowser/browser/webengine/webenginesettings.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index d1536471d..3002fcd45 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -92,6 +92,9 @@ Fixed - Searching via `/` or `?` now doesn't handle any characters in a special way. - Fixed crash when trying to retry some failed downloads on QtWebEngine. - An invalid spellcheck dictionary filename now doesn't crash anymore. +- When no spellcheck dictionaries are configured, it's now disabled internally. + This works around an issue with entering special characters on Facebook + messenger. v1.2.1 ------ diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py index 417465929..e3efc780c 100644 --- a/qutebrowser/browser/webengine/webenginesettings.py +++ b/qutebrowser/browser/webengine/webenginesettings.py @@ -179,7 +179,6 @@ class ProfileSetter: self._profile.settings().setAttribute( QWebEngineSettings.FullScreenSupportEnabled, True) if qtutils.version_check('5.8'): - self._profile.setSpellCheckEnabled(True) self.set_dictionary_language() def set_http_headers(self): @@ -230,6 +229,7 @@ class ProfileSetter: log.config.debug("Found dicts: {}".format(filenames)) self._profile.setSpellCheckLanguages(filenames) + self._profile.setSpellCheckEnabled(bool(filenames)) def _update_settings(option):