rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Perfect coverage for sortfilter.

Browse Source 
Mark an area of sortfilter with `#pragma no coverage` and add it to
perfect_files.
This commit is contained in:
Ryan Roden-Corrent 2016-08-06 20:48:21 -04:00
parent 3e1409b1f5
commit adc428e525
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/completion/models/sortfilter.py
View File

@ -135,8 +135,8 @@ class CompletionFilterModel(QSortFilterProxyModel):
for col in self.srcmodel.columns_to_filter: for col in self.srcmodel.columns_to_filter:
idx = self.srcmodel.index(row, col, parent) idx = self.srcmodel.index(row, col, parent)
if not idx.isValid(): if not idx.isValid(): # pragma: no cover
# No entries in parent model # this is a sanity check not hit by any test case
continue continue
data = self.srcmodel.data(idx) data = self.srcmodel.data(idx)
if not data: if not data:

2
scripts/dev/check_coverage.py
View File

@ -150,6 +150,8 @@ PERFECT_FILES = [
('tests/unit/completion/test_models.py', ('tests/unit/completion/test_models.py',
'qutebrowser/completion/models/base.py'), 'qutebrowser/completion/models/base.py'),
('tests/unit/completion/test_sortfilter.py',
'qutebrowser/completion/models/sortfilter.py'),
] ]