From ad8c9988f0ec42085ab06ae3c0ce81a7194b81aa Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 11 Nov 2015 22:23:43 +0100 Subject: [PATCH] Fix lint. --- scripts/dev/check_coverage.py | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/scripts/dev/check_coverage.py b/scripts/dev/check_coverage.py index 41cb51cce..f9914b5d7 100644 --- a/scripts/dev/check_coverage.py +++ b/scripts/dev/check_coverage.py @@ -142,6 +142,19 @@ class Skipped(Exception): super().__init__("Skipping coverage checks " + reason) +def _get_filename(filename): + """Transform the absolute test filenames to relative ones.""" + if os.path.isabs(filename): + basedir = os.path.abspath( + os.path.join(os.path.dirname(__file__), '..', '..')) + common_path = os.path.commonprefix([basedir, filename]) + if common_path: + filename = filename[len(common_path):].lstrip('/') + + return filename + + + def check(fileobj, perfect_files): """Main entry point which parses/checks coverage.xml if applicable.""" if sys.platform != 'linux': @@ -167,14 +180,7 @@ def check(fileobj, perfect_files): messages = [] for klass in classes: - filename = klass.attrib['filename'] - - basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), '..', - '..')) - if os.path.isabs(filename): - common_path = os.path.commonprefix([basedir, filename]) - if common_path: - filename = filename[len(common_path):].lstrip('/') + filename = _get_filename(klass.attrib['filename']) line_cov = float(klass.attrib['line-rate']) * 100 branch_cov = float(klass.attrib['branch-rate']) * 100