rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add quotes for strings in javascript.assemble

Browse Source
This commit is contained in:
Florian Bruhin 2016-08-04 17:58:40 +02:00
parent 08b70f0f4c
commit a8ef956726
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/utils/javascript.py
View File

@ -54,7 +54,7 @@ def _convert_js_arg(arg):
if arg is None: if arg is None:
return 'undefined' return 'undefined'
elif isinstance(arg, str): elif isinstance(arg, str):
return string_escape(arg) return '"{}"'.format(string_escape(arg))
elif isinstance(arg, int): elif isinstance(arg, int):
return str(arg) return str(arg)
else: else:

4
tests/unit/utils/test_javascript.py
View File

@ -123,8 +123,8 @@ class TestStringEscape:
@pytest.mark.parametrize('arg, expected', [ @pytest.mark.parametrize('arg, expected', [
('foobar', 'foobar'), ('foobar', '"foobar"'),
('foo\\bar', r'foo\\bar'), ('foo\\bar', r'"foo\\bar"'),
(42, '42'), (42, '42'),
(None, 'undefined'), (None, 'undefined'),
(object(), TypeError), (object(), TypeError),