rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rewrite test_on_next_prev_item after refactoring.

Browse Source 
Check the value of the signal emitted after each one of a series of
next/prev_item calls.
This commit is contained in:
Ryan Roden-Corrent 2016-09-15 07:41:56 -04:00
parent a9771007b1
commit a7eea6a0c1
1 changed files with 51 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

111
tests/unit/completion/test_completionwidget.py
View File

@ -96,64 +96,56 @@ def test_maybe_resize_completion(completionview, config_stub, qtbot):
completionview.maybe_resize_completion() completionview.maybe_resize_completion()
@pytest.mark.parametrize('which, tree, count, expected', [ @pytest.mark.parametrize('which, tree, expected', [
('next', [['Aa']], 1, 'Aa'), ('next', [['Aa']], ['Aa', None, None]),
('prev', [['Aa']], 1, 'Aa'), ('prev', [['Aa']], ['Aa', None, None]),
('next', [['Aa'], ['Ba']], 1, 'Aa'), ('next', [['Aa'], ['Ba']], ['Aa', 'Ba', 'Aa']),
('prev', [['Aa'], ['Ba']], 1, 'Ba'), ('prev', [['Aa'], ['Ba']], ['Ba', 'Aa', 'Ba']),
('next', [['Aa'], ['Ba']], 2, 'Ba'), ('next', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
('prev', [['Aa'], ['Ba']], 2, 'Aa'), ['Aa', 'Ab', 'Ac', 'Ba', 'Bb', 'Ca', 'Aa']),
('next', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 3, 'Ac'), ('prev', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
('next', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 4, 'Ba'), ['Ca', 'Bb', 'Ba', 'Ac', 'Ab', 'Aa', 'Ca']),
('next', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 6, 'Ca'), ('next', [[], ['Ba', 'Bb']], ['Ba', 'Bb', 'Ba']),
('next', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 7, 'Aa'), ('prev', [[], ['Ba', 'Bb']], ['Bb', 'Ba', 'Bb']),
('prev', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 1, 'Ca'), ('next', [[], [], ['Ca', 'Cb']], ['Ca', 'Cb', 'Ca']),
('prev', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 2, 'Bb'), ('prev', [[], [], ['Ca', 'Cb']], ['Cb', 'Ca', 'Cb']),
('prev', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 4, 'Ac'), ('next', [['Aa'], []], ['Aa', None]),
('next', [[], ['Ba', 'Bb']], 1, 'Ba'), ('prev', [['Aa'], []], ['Aa', None]),
('prev', [[], ['Ba', 'Bb']], 1, 'Bb'), ('next', [['Aa'], [], []], ['Aa', None]),
('next', [[], [], ['Ca', 'Cb']], 1, 'Ca'), ('prev', [['Aa'], [], []], ['Aa', None]),
('prev', [[], [], ['Ca', 'Cb']], 1, 'Cb'), ('next', [['Aa'], [], ['Ca', 'Cb']], ['Aa', 'Ca', 'Cb', 'Aa']),
('next', [['Aa'], []], 1, 'Aa'), ('prev', [['Aa'], [], ['Ca', 'Cb']], ['Cb', 'Ca', 'Aa', 'Cb']),
('prev', [['Aa'], []], 1, 'Aa'), ('next', [[]], [None, None]),
('next', [['Aa'], [], []], 1, 'Aa'), ('prev', [[]], [None, None]),
('prev', [['Aa'], [], []], 1, 'Aa'), ('next-category', [['Aa']], ['Aa', None, None]),
('next', [['Aa'], [], ['Ca', 'Cb']], 2, 'Ca'), ('prev-category', [['Aa']], ['Aa', None, None]),
('prev', [['Aa'], [], ['Ca', 'Cb']], 1, 'Cb'), ('next-category', [['Aa'], ['Ba']], ['Aa', 'Ba', 'Aa']),
('next', [[]], 1, None), ('prev-category', [['Aa'], ['Ba']], ['Ba', 'Aa', 'Ba']),
('prev', [[]], 1, None), ('next-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
('next-category', [['Aa']], 1, 'Aa'), ['Aa', 'Ba', 'Ca', 'Aa']),
('prev-category', [['Aa']], 1, 'Aa'), ('prev-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
('next-category', [['Aa'], ['Ba']], 1, 'Aa'), ['Ca', 'Ba', 'Aa', 'Ca']),
('prev-category', [['Aa'], ['Ba']], 1, 'Ba'), ('next-category', [[], ['Ba', 'Bb']], ['Ba', None, None]),
('next-category', [['Aa'], ['Ba']], 2, 'Ba'), ('prev-category', [[], ['Ba', 'Bb']], ['Ba', None, None]),
('prev-category', [['Aa'], ['Ba']], 2, 'Aa'), ('next-category', [[], [], ['Ca', 'Cb']], ['Ca', None, None]),
('next-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 2, 'Ba'), ('prev-category', [[], [], ['Ca', 'Cb']], ['Ca', None, None]),
('prev-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 2, 'Ba'), ('next-category', [['Aa'], [], []], ['Aa', None, None]),
('next-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 3, 'Ca'), ('prev-category', [['Aa'], [], []], ['Aa', None, None]),
('prev-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']], 3, 'Aa'), ('next-category', [['Aa'], [], ['Ca', 'Cb']], ['Aa', 'Ca', 'Aa']),
('next-category', [[], ['Ba', 'Bb']], 1, 'Ba'), ('prev-category', [['Aa'], [], ['Ca', 'Cb']], ['Ca', 'Aa', 'Ca']),
('prev-category', [[], ['Ba', 'Bb']], 1, 'Ba'), ('next-category', [[]], [None, None]),
('next-category', [[], [], ['Ca', 'Cb']], 1, 'Ca'), ('prev-category', [[]], [None, None]),
('prev-category', [[], [], ['Ca', 'Cb']], 1, 'Ca'),
('next-category', [[], [], ['Ca', 'Cb']], 2, 'Ca'),
('prev-category', [[], [], ['Ca', 'Cb']], 2, 'Ca'),
('next-category', [['Aa'], [], []], 1, 'Aa'),
('prev-category', [['Aa'], [], []], 1, 'Aa'),
('next-category', [['Aa'], [], ['Ca', 'Cb']], 2, 'Ca'),
('prev-category', [['Aa'], [], ['Ca', 'Cb']], 1, 'Ca'),
('next-category', [[]], 1, None),
('prev-category', [[]], 1, None),
]) ])
def test_completion_item_focus(which, tree, count, expected, completionview, def test_completion_item_focus(which, tree, expected, completionview, qtbot):
qtbot):
"""Test that on_next_prev_item moves the selection properly. """Test that on_next_prev_item moves the selection properly.
Args: Args:
which: the direction in which to move the selection.
tree: Each list represents a completion category, with each string tree: Each list represents a completion category, with each string
being an item under that category. being an item under that category.
count: Number of times to go forward (or back if negative). expected: expected argument from on_selection_changed for each
expected: item data that should be selected after going back/forward. successive movement. None implies no signal should be
emitted.
""" """
model = base.BaseCompletionModel() model = base.BaseCompletionModel()
for catdata in tree: for catdata in tree:
@ -164,15 +156,14 @@ def test_completion_item_focus(which, tree, count, expected, completionview,
filtermodel = sortfilter.CompletionFilterModel(model, filtermodel = sortfilter.CompletionFilterModel(model,
parent=completionview) parent=completionview)
completionview.set_model(filtermodel) completionview.set_model(filtermodel)
if expected is None: for entry in expected:
for _ in range(count): if entry is None:
completionview.completion_item_focus(which) with qtbot.assertNotEmitted(completionview.selection_changed):
else:
with qtbot.waitSignal(completionview.selection_changed):
for _ in range(count):
completionview.completion_item_focus(which) completionview.completion_item_focus(which)
idx = completionview.selectionModel().currentIndex() else:
assert filtermodel.data(idx) == expected with qtbot.waitSignal(completionview.selection_changed) as sig:
completionview.completion_item_focus(which)
assert sig.args == [entry]
@pytest.mark.parametrize('which', ['next', 'prev', 'next-category', @pytest.mark.parametrize('which', ['next', 'prev', 'next-category',