From a7af5195d14a0604e6809f58e97b168b78493dda Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 28 Jun 2018 11:22:44 +0200 Subject: [PATCH] Set title when showing PDF.js error page Fixes #3894 --- doc/changelog.asciidoc | 2 ++ qutebrowser/browser/webkit/webpage.py | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index f4c62a713..64a051ad0 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -116,6 +116,8 @@ Fixed - The security fix in v1.3.3 caused URLs with ampersands (`www.example.com?one=1&two=2`) to send the wrong arguments when clicked on the `qute://history` page. +- Crash when opening a PDF page with PDF.js enabled (on QtWebKit), but no + PDF.js installed. Removed ~~~~~~~ diff --git a/qutebrowser/browser/webkit/webpage.py b/qutebrowser/browser/webkit/webpage.py index 853ff1b81..a6c26c8ee 100644 --- a/qutebrowser/browser/webkit/webpage.py +++ b/qutebrowser/browser/webkit/webpage.py @@ -212,7 +212,8 @@ class BrowserPage(QWebPage): page = pdfjs.generate_pdfjs_page(reply.url()) except pdfjs.PDFJSNotFound: page = jinja.render('no_pdfjs.html', - url=reply.url().toDisplayString()) + url=reply.url().toDisplayString(), + title="PDF.js not found") self.mainFrame().setContent(page.encode('utf-8'), 'text/html', reply.url()) reply.deleteLater()