From a6b314ae91fc56de279d6bb9a63671f69909df85 Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Mon, 11 Jun 2018 21:21:41 +0200
Subject: [PATCH] Don't connect Qt 5.11 signals on PyQt 5.10
Apparently the signal attributes already exist with PyQt 5.10 (*sigh*) but PyQt
doesn't know what to do with the arguments, causing this to happen:
TypeError: unable to convert a C++ 'QWebEngineRegisterProtocolHandlerRequest'
instance to a Python object
---
qutebrowser/browser/webengine/webenginetab.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py
index f0cf32793..7c4d279c7 100644
--- a/qutebrowser/browser/webengine/webenginetab.py
+++ b/qutebrowser/browser/webengine/webenginetab.py
@@ -660,14 +660,12 @@ class _WebEnginePermissions(QObject):
self._on_fullscreen_requested)
page.featurePermissionRequested.connect(
self._on_feature_permission_requested)
- try:
+
+ if qtutils.version_check('5.11'):
page.quotaRequested.connect(
self._on_quota_requested)
page.registerProtocolHandlerRequested.connect(
self._on_register_protocol_handler_requested)
- except AttributeError:
- # Added in Qt 5.11
- pass
self._tab.shutting_down.connect(self._abort_questions)
self._tab.load_started.connect(self._abort_questions)