rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set content.cookies.accept to all by default

Browse Source 
Setting it to no-3rdparty is a nice idea from a "privacy by default"
perspective, but it also breaks various pages.

In particular, due to what's probably a Qt bug, it breaks the new GMail:
https://bugreports.qt.io/browse/QTBUG-71393

Let's be in line with what other browsers by default here.

Fixes #4281
This commit is contained in:
Florian Bruhin 2018-10-26 10:13:37 +02:00
parent 5ce1229ee5
commit a5dba34088
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/help/settings.asciidoc
View File

@ -1591,11 +1591,11 @@ Type: <<types,String>>
Valid values: Valid values:
* +all+: Accept all cookies. * +all+: Accept all cookies.
* +no-3rdparty+: Accept cookies from the same origin only. * +no-3rdparty+: Accept cookies from the same origin only. This is known to break some sites, such as GMail.
* +no-unknown-3rdparty+: Accept cookies from the same origin only, unless a cookie is already set for the domain. On QtWebEngine, this is the same as no-3rdparty. * +no-unknown-3rdparty+: Accept cookies from the same origin only, unless a cookie is already set for the domain. On QtWebEngine, this is the same as no-3rdparty.
* +never+: Don't accept cookies at all. * +never+: Don't accept cookies at all.
Default: +pass:[no-3rdparty]+ Default: +pass:[all]+
On QtWebEngine, this setting requires Qt 5.11 or newer. On QtWebEngine, this setting requires Qt 5.11 or newer.

5
qutebrowser/config/configdata.yml
View File

@ -329,7 +329,7 @@ content.cache.appcache:
ask the application cache for the contents, before hitting the network. ask the application cache for the contents, before hitting the network.
content.cookies.accept: content.cookies.accept:
default: no-3rdparty default: all
backend: backend:
QtWebKit: true QtWebKit: true
QtWebEngine: Qt 5.11 QtWebEngine: Qt 5.11
@ -337,7 +337,8 @@ content.cookies.accept:
name: String name: String
valid_values: valid_values:
- all: "Accept all cookies." - all: "Accept all cookies."
- no-3rdparty: "Accept cookies from the same origin only." - no-3rdparty: "Accept cookies from the same origin only. This is known
to break some sites, such as GMail."
- no-unknown-3rdparty: "Accept cookies from the same origin only, unless - no-unknown-3rdparty: "Accept cookies from the same origin only, unless
a cookie is already set for the domain. On QtWebEngine, this is the a cookie is already set for the domain. On QtWebEngine, this is the
same as no-3rdparty." same as no-3rdparty."