rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up javascript double-close test

Browse Source 
The test for QtWebEngine was removed because something weird happened
with the two pytest-bdd tags, and I'm too annoyed with everything being
broken to investigate now... Future me, I'm sorry.
This commit is contained in:
Florian Bruhin 2016-09-05 14:41:05 +02:00
parent ce98d89352
commit a52c8d6576
3 changed files with 8 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/end2end/data/javascript/issue906.html
View File

@ -1,22 +0,0 @@
<!DOCTYPE html>
<html>
<body>
<button onclick="openWin()" id="open-button">Open "myWindow"</button>
<button onclick="closeWin()" id="close-button">Close "myWindow"</button>
<script>
var myWindow;
function openWin() {
myWindow = window.open("about:blank", "myWindow", "width=200, height=100");
}
function closeWin() {
myWindow.close();
myWindow.close();
}
</script>
</body>
</html>

5
tests/end2end/data/javascript/window_open.html
View File

@ -20,6 +20,11 @@
function close() { function close() {
my_window.close(); my_window.close();
} }
function close_twice() {
my_window.close();
my_window.close();
}
</script> </script>
</head> </head>

19
tests/end2end/features/javascript.feature
View File

@ -36,22 +36,9 @@ Feature: Javascript stuff
Scenario: Closing a JS window twice (issue 906) - qtwebkit Scenario: Closing a JS window twice (issue 906) - qtwebkit
When I open about:blank When I open about:blank
And I run :tab-only And I run :tab-only
When I open data/javascript/issue906.html in a new tab When I open data/javascript/window_open.html in a new tab
And I run :click-element id open-button And I run :click-element id open-normal
And I wait for "Changing title for idx 2 to 'about:blank'" in the log And I wait for "Changing title for idx 2 to 'about:blank'" in the log
And I run :tab-focus 2 And I run :tab-focus 2
And I run :click-element id close-button And I run :click-element id close-twice
Then "Requested to close * which does not exist!" should be logged Then "Requested to close * which does not exist!" should be logged
@qtwebengine_createWindow @qtwebkit_skip
Scenario: Closing a JS window twice (issue 906) - qtwebengine
When I open about:blank
And I run :tab-only
And I open data/javascript/issue906.html in a new tab
And I run :click-element id open-button
And I wait for "WebDialog requested, but we don't support that!" in the log
And I wait for "Changing title for idx 2 to 'about:blank'" in the log
And I run :tab-focus 2
And I run :click-element id close-button
And I wait for "Focus object changed: *" in the log
Then no crash should happen