From a3482a89793484537c0902c2e3599be6ca1a006b Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 23 Nov 2016 12:37:19 +0100 Subject: [PATCH] Lowercase special keys when checking if they're new Between v0.8.4 and now, the default keybinding for Ctrl-PgDown changed: - ('tab-focus', ['J', '']), + ('tab-next', ['J', '']), The existing keybinding was lower-cased in the config, but _is_new didn't lowercase the new one, causing a conflict to show up. Fixes #1835 See #1958 Supersedes #1986 --- qutebrowser/config/parsers/keyconf.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qutebrowser/config/parsers/keyconf.py b/qutebrowser/config/parsers/keyconf.py index e602c33d5..3a658c4b1 100644 --- a/qutebrowser/config/parsers/keyconf.py +++ b/qutebrowser/config/parsers/keyconf.py @@ -280,6 +280,9 @@ class KeyConfigParser(QObject): A binding is considered new if both the command is not bound to any key yet, and the key isn't used anywhere else in the same section. """ + if utils.is_special_key(keychain): + keychain = keychain.lower() + try: bindings = self.keybindings[sectname] except KeyError: